From: Glauber Costa <glommer@parallels•com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp•fujitsu.com>
Cc: <linux-kernel@vger•kernel.org>, <paul@paulmenage•org>,
<lizf@cn•fujitsu.com>, <ebiederm@xmission•com>,
<davem@davemloft•net>, <gthelen@google•com>,
<netdev@vger•kernel.org>, <linux-mm@kvack•org>,
<kirill@shutemov•name>
Subject: Re: [PATCH v3 4/7] per-cgroup tcp buffers control
Date: Mon, 26 Sep 2011 19:48:15 -0300 [thread overview]
Message-ID: <4E81012F.2070001@parallels.com> (raw)
In-Reply-To: <20110926195906.f1f5831c.kamezawa.hiroyu@jp.fujitsu.com>
On 09/26/2011 07:59 AM, KAMEZAWA Hiroyuki wrote:
> On Sun, 18 Sep 2011 21:56:42 -0300
> Glauber Costa<glommer@parallels•com> wrote:
>
>> With all the infrastructure in place, this patch implements
>> per-cgroup control for tcp memory pressure handling.
>>
>> Signed-off-by: Glauber Costa<glommer@parallels•com>
>> CC: David S. Miller<davem@davemloft•net>
>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp•fujitsu.com>
>> CC: Eric W. Biederman<ebiederm@xmission•com>
>
> a comment below.
>
>> +int tcp_init_cgroup(struct proto *prot, struct cgroup *cgrp,
>> + struct cgroup_subsys *ss)
>> +{
>> + struct mem_cgroup *cg = mem_cgroup_from_cont(cgrp);
>> + unsigned long limit;
>> +
>> + cg->tcp_memory_pressure = 0;
>> + atomic_long_set(&cg->tcp_memory_allocated, 0);
>> + percpu_counter_init(&cg->tcp_sockets_allocated, 0);
>> +
>> + limit = nr_free_buffer_pages() / 8;
>> + limit = max(limit, 128UL);
>> +
>> + cg->tcp_prot_mem[0] = sysctl_tcp_mem[0];
>> + cg->tcp_prot_mem[1] = sysctl_tcp_mem[1];
>> + cg->tcp_prot_mem[2] = sysctl_tcp_mem[2];
>> +
>
> Then, the parameter doesn't inherit parent's one ?
>
> I think sockets_populate should pass 'parent' and
>
>
> I think you should have a function
>
> mem_cgroup_should_inherit_parent_settings(parent)
>
> (This is because you made this feature as a part of memcg.
> please provide expected behavior.)
>
All right Kame, will do.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack•org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack•org"> email@kvack•org </a>
next prev parent reply other threads:[~2011-09-26 22:48 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 0:56 [PATCH v3 0/7] per-cgroup tcp buffer pressure settings Glauber Costa
2011-09-19 0:56 ` [PATCH v3 1/7] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-09-21 2:23 ` Glauber Costa
2011-09-22 3:17 ` Balbir Singh
2011-09-22 3:19 ` Glauber Costa
2011-09-24 14:43 ` Glauber Costa
2011-09-27 10:06 ` Balbir Singh
2011-09-22 5:58 ` Greg Thelen
2011-09-26 10:34 ` KAMEZAWA Hiroyuki
2011-09-26 22:44 ` Glauber Costa
2011-09-26 23:18 ` Glauber Costa
2011-09-28 0:58 ` KAMEZAWA Hiroyuki
2011-09-28 12:03 ` Glauber Costa
2011-09-19 0:56 ` [PATCH v3 2/7] socket: initial cgroup code Glauber Costa
2011-09-21 18:47 ` Greg Thelen
2011-09-21 18:59 ` Glauber Costa
2011-09-22 6:00 ` Greg Thelen
2011-09-22 15:09 ` Balbir Singh
2011-09-24 13:33 ` Glauber Costa
2011-09-24 13:40 ` Glauber Costa
2011-09-24 14:45 ` Glauber Costa
2011-09-26 10:52 ` KAMEZAWA Hiroyuki
2011-09-26 22:47 ` Glauber Costa
2011-09-28 0:56 ` KAMEZAWA Hiroyuki
2011-09-27 20:43 ` Glauber Costa
2011-09-19 0:56 ` [PATCH v3 3/7] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-09-19 0:56 ` [PATCH v3 4/7] per-cgroup tcp buffers control Glauber Costa
2011-09-26 10:59 ` KAMEZAWA Hiroyuki
2011-09-26 22:48 ` Glauber Costa [this message]
2011-09-27 1:53 ` Glauber Costa
2011-09-28 1:09 ` KAMEZAWA Hiroyuki
2011-09-26 14:39 ` Andrew Vagin
2011-09-26 22:52 ` Glauber Costa
2011-09-19 0:56 ` [PATCH v3 5/7] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-09-19 0:56 ` [PATCH v3 6/7] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-09-22 6:01 ` Greg Thelen
2011-09-22 9:58 ` Kirill A. Shutemov
2011-09-22 15:44 ` Greg Thelen
2011-09-24 13:30 ` Glauber Costa
2011-09-26 11:02 ` KAMEZAWA Hiroyuki
2011-09-26 22:49 ` Glauber Costa
2011-09-22 23:08 ` Balbir Singh
2011-09-24 13:35 ` Glauber Costa
2011-09-24 16:58 ` Andi Kleen
2011-09-24 17:27 ` Glauber Costa
2011-09-28 2:29 ` Balbir Singh
2011-09-28 3:06 ` Andi Kleen
2011-09-19 0:56 ` [PATCH v3 7/7] Display current tcp memory allocation in kmem cgroup Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81012F.2070001@parallels.com \
--to=glommer@parallels$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=gthelen@google$(echo .)com \
--cc=kamezawa.hiroyu@jp$(echo .)fujitsu.com \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=lizf@cn$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paul@paulmenage$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox