From: David Daney <david.daney@cavium•com>
To: "Michał Mirosław" <mirqus@gmail•com>
Cc: devicetree-discuss@lists•ozlabs.org, grant.likely@secretlab•ca,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
davem@davemloft•net
Subject: Re: [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support.
Date: Wed, 28 Sep 2011 10:42:09 -0700 [thread overview]
Message-ID: <4E835C71.1010108@cavium.com> (raw)
In-Reply-To: <CAHXqBF+ZVbCGEvnCcOtHk+sOWFLp1CuEnGLq+GEtHQTpu9PuYg@mail.gmail.com>
On 09/28/2011 10:32 AM, Michał Mirosław wrote:
> W dniu 28 września 2011 18:51 użytkownik David Daney
> <david.daney@cavium•com> napisał:
>> On 09/28/2011 12:25 AM, Michał Mirosław wrote:
>>>
>>> 2011/9/28 David Daney<david.daney@cavium•com>:
>>> [...]
>>>>
>>>> +Example :
>>>> +
>>>> + /* The parent MDIO bus. */
>>>> + smi1: mdio@1180000001900 {
>>>> + compatible = "cavium,octeon-3860-mdio";
>>>> + #address-cells =<1>;
>>>> + #size-cells =<0>;
>>>> + reg =<0x11800 0x00001900 0x0 0x40>;
>>>> + };
>>>> +
>>>> + /*
>>>> + An NXP sn74cbtlv3253 dual 1-of-4 switch controlled by a
>>>> + pair of GPIO lines. Child busses 2 and 3 populated with 4
>>>> + PHYs each.
>>>> + */
>>>> + mdio-mux {
>>>> + compatible = "cavium,mdio-mux-sn74cbtlv3253",
>>>> "cavium,mdio-mux";
>>>> + gpios =<&gpio1 3 0>,<&gpio1 4 0>;
>>>> + mdio-parent-bus =<&smi1>;
>>>> + #address-cells =<1>;
>>>> + #size-cells =<0>;
>>>
>>> This should probably have 'compatible = "nxp,sn74cbtlv3253";' here.
>>>
>>
>> No, the sn74cbtlv3253 is a general purpose part that could be used to
>> multiplex anything (I2C, SPI, random analog signals, etc.). Only when it is
>> in the "cavium,mdio-mux-sn74cbtlv3253" configuration is it an MDIO bus
>> multiplexer.
>
> This should use some generic name then. 'mdio-mux-gpio' or something.
> There's no point in introducing chip's model for a gate-like discrete
> device.
That could be. We could define an "mdio-mux-gpio" as something that
selects the child bus based on the binary encoded value presented on the
GPIO lines.
I will regenerate the patch set with this in mind. Note that the only
part of this patch that will change is this mdio-mux.txt file, no actual
code is affected. In patch 3/3 I will add "mdio-mux-gpio" to the
.of_match_table.
Thanks,
David Daney
next prev parent reply other threads:[~2011-09-28 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 23:26 [PATCH v2 0/3] netdev/of/phy: MDIO bus multiplexer support David Daney
2011-09-27 23:26 ` [PATCH v2 1/3] netdev/of/phy: New function: of_mdio_find_bus() David Daney
2011-09-29 21:41 ` Grant Likely
[not found] ` <1317166015-20714-1-git-send-email-david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2011-09-27 23:26 ` [PATCH v2 2/3] netdev/of/phy: Add MDIO bus multiplexer support David Daney
2011-09-28 7:25 ` Michał Mirosław
2011-09-28 16:51 ` David Daney
2011-09-28 17:32 ` Michał Mirosław
2011-09-28 17:42 ` David Daney [this message]
2011-09-29 21:56 ` Grant Likely
2011-09-27 23:26 ` [PATCH v2 3/3] netdev/of/phy: Add MDIO bus multiplexer driven by GPIO lines David Daney
[not found] ` <1317166015-20714-4-git-send-email-david.daney-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2011-09-29 22:01 ` Grant Likely
2011-09-29 20:31 ` [PATCH v2 0/3] netdev/of/phy: MDIO bus multiplexer support David Miller
2011-09-30 0:32 ` Grant Likely
[not found] ` <20110930003214.GB12606-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-10-17 14:48 ` Kumar Gala
2011-10-17 15:41 ` David Daney
2012-04-13 19:08 ` Andy Fleming
2012-04-13 19:51 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E835C71.1010108@cavium.com \
--to=david.daney@cavium$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mirqus@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox