Subject: Re: [PATCH] net: sh_eth: fix build failure

From: Yoshihiro Shimoda <[email-masked]>
Date: Fri, 30 Sep 2011 16:51:34 +0900

2011/09/30 15:55, Nobuhiro Iwamatsu wrote:
> 2011/9/30 Yoshihiro Shimoda <[email-masked]>:
< snip >
>> +#include <linux/kernel.h>
>> +#include <linux/spinlock.h>
> These are not required.

The Documentation/SubmitChecklist says the following:

========================================================
1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.
========================================================

The sh_eth driver uses spinlock functions and some macros of kernel.h.
So, I think that I have to write their "#include" in the driver.

Best regards,
Yoshihiro Shimoda

> Best regards,
>   Nobuhiro
> Nobuhiro Iwamatsu