From: Oliver Hartkopp <socketcan@hartkopp•net>
To: Wolfram Sang <w.sang@pengutronix•de>,
Wolfgang Grandegger <wg@grandegger•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
Andre Naujoks <nautsch@gmail•com>
Subject: Re: [PATCH net] mscan: zero accidentally copied register content
Date: Thu, 06 Oct 2011 16:01:45 +0200 [thread overview]
Message-ID: <4E8DB4C9.30109@hartkopp.net> (raw)
In-Reply-To: <20111006092456.GB1974@pengutronix.de>
On 10/06/11 11:24, Wolfram Sang wrote:
>
>> Why do you want to change 16-bit accesses in general? They are faster
>> than two 8 bit accesses.
>
> Yup, was thinking the same.
Ah, i did not get this from your code example
if (can_dlc & 1)
*payload = in_be16() & mask;
which probably does the same as Wolfgangs more obvious suggestion
if (frame->can_dlc & 1)
frame->data[frame->can_dlc - 1] = in_8(data);
:-)
As my patch could be done without real testing, as i did not change the
register access and only fixed the result ...
if (frame->can_dlc & 1)
frame->data[frame->can_dlc] = 0;
... it would be nice if e.g. Wolfgang could send his patch after some testing,
as i currently don't have access to my MPC5200 hardware here.
Tnx & best regards,
Oliver
next prev parent reply other threads:[~2011-10-06 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 15:34 [PATCH net] mscan: zero accidentally copied register content Oliver Hartkopp
2011-10-05 15:51 ` Wolfram Sang
2011-10-05 16:10 ` Oliver Hartkopp
2011-10-06 7:02 ` Oliver Hartkopp
2011-10-06 9:09 ` Wolfgang Grandegger
2011-10-06 9:24 ` Wolfram Sang
2011-10-06 14:01 ` Oliver Hartkopp [this message]
2011-10-06 14:09 ` Wolfram Sang
2011-10-06 14:14 ` Andre Naujoks
2011-10-06 14:33 ` Oliver Hartkopp
2011-10-06 15:03 ` Andre Naujoks
2011-10-06 18:24 ` Wolfgang Grandegger
2011-10-10 16:38 ` Oliver Hartkopp
2011-10-06 18:25 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8DB4C9.30109@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=nautsch@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=w.sang@pengutronix$(echo .)de \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox