Subject: Re: [PATCH] netconsole: enable netconsole can make net_device refcnt

From: Gao feng <[email-masked]>
Date: Wed, 12 Oct 2011 09:45:55 +0800

12.10.2011 09:11, Flavio Leitner wrote:
> On Tue, 11 Oct 2011 16:05:48 +0800
> Gao feng <[email-masked]> wrote:
> 
>> Im so sorry.
>> the first patch has some format err.
>> Please use this one.
>> thanks wanlong! ^V^
>>
>> 11.10.2011 15:50, Wanlong Gao wrote:
>>> There is no check if netconsole is enabled current.
>>> so when exec echo 1 > enabled;
>>> the reference of net_device will increment always.
>>>
>>> Signed-off-by: Gao feng <[email-masked]>
>>> ---
>>>  drivers/net/netconsole.c |    2 ++
>>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
>>> index ed2a397..4e6323df 100644
>>> --- a/drivers/net/netconsole.c
>>> +++ b/drivers/net/netconsole.c
>>> @@ -307,6 +307,8 @@ static ssize_t store_enabled(struct
>>> netconsole_target *nt, return err;
>>>  	if (enabled < 0 || enabled > 1)
>>>  		return -EINVAL;
>>> +	if (enabled == nt->enabled)
>>> +		return err;
> 
> It looks like 'err' will be 0.  Maybe it is better to
> return -EINVAL?
> 
> fbl
> 

Yes,you are right,and I will add some printk.thanks.