From: Stanislav Kinsbursky <skinsbursky@parallels•com>
To: "J. Bruce Fields" <bfields@fieldses•org>
Cc: "Trond.Myklebust@netapp•com" <Trond.Myklebust@netapp•com>,
"linux-nfs@vger•kernel.org" <linux-nfs@vger•kernel.org>,
Pavel Emelianov <xemul@parallels•com>,
"neilb@suse•de" <neilb@suse•de>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"davem@davemloft•net" <davem@davemloft•net>,
"devel@openvz•org" <devel@openvz•org>
Subject: Re: [PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it
Date: Fri, 28 Oct 2011 13:27:01 +0400 [thread overview]
Message-ID: <4EAA7565.1040101@parallels.com> (raw)
In-Reply-To: <20111027212732.GC31669@fieldses.org>
28.10.2011 01:27, J. Bruce Fields пишет:
> On Tue, Oct 25, 2011 at 02:17:08PM +0300, Stanislav Kinsbursky wrote:
>> New function ("svc_uses_rpcbind") will be used to detect, that new service will
>> send portmapper register calls. For such services we will create rpcbind
>> clients and remove all stale portmap registrations.
>> Also, svc_rpcb_cleanup() will be set as sv_shutdown callback for such services
>> in case of this field wasn't initialized earlier. This will allow to destroy
>> rpcbind clients when no other users of them left.
>>
>> Note: Currently, any creating service will be detected as portmap user.
>> Probably, this is wrong. But now it depends on program versions "vs_hidden"
>> flag.
>>
>> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels•com>
>>
>> ---
>> net/sunrpc/svc.c | 11 +++++++++--
>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
>> index d2d61bf..918edc3 100644
>> --- a/net/sunrpc/svc.c
>> +++ b/net/sunrpc/svc.c
>> @@ -454,8 +454,15 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
>> spin_lock_init(&pool->sp_lock);
>> }
>>
>> - /* Remove any stale portmap registrations */
>> - svc_unregister(serv);
>> + if (svc_uses_rpcbind(serv)) {
>> + if (svc_rpcb_setup(serv)< 0) {
>> + kfree(serv->sv_pools);
>> + kfree(serv);
>> + return NULL;
>
> Nit: could we convert this (and the previous failure to allocate
> sv_pools) to the usual pattern of collecting the cleanup at the end and
> jumping to it with a goto?
>
Sure, we can. I will implement this "goto pattern", is you insist.
> Looks fine otherwise.
>
> --b.
>
>> + }
>> + if (!serv->sv_shutdown)
>> + serv->sv_shutdown = svc_rpcb_cleanup;
>> + }
>>
>> return serv;
>> }
>>
--
Best regards,
Stanislav Kinsbursky
next prev parent reply other threads:[~2011-10-28 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 11:15 [PATCH v6 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically Stanislav Kinsbursky
2011-10-25 11:16 ` [PATCH v6 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients Stanislav Kinsbursky
[not found] ` <20111025101608.12689.68689.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-10-25 11:16 ` Trond Myklebust
2011-10-25 12:41 ` Stanislav Kinsbursky
[not found] ` <4EA6AE87.5000309-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-10-25 12:45 ` Trond Myklebust
2011-10-25 13:25 ` Stanislav Kinsbursky
2011-10-25 11:16 ` [PATCH v6 2/8] SUNRPC: use rpcbind reference counting helpers Stanislav Kinsbursky
2011-10-25 11:16 ` [PATCH v6 3/8] SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 4/8] SUNRPC: setup rpcbind clients if service requires it Stanislav Kinsbursky
[not found] ` <20111025101705.12689.68022.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2011-10-27 21:27 ` J. Bruce Fields
2011-10-28 9:27 ` Stanislav Kinsbursky [this message]
2011-10-25 11:17 ` [PATCH v6 5/8] SUNRPC: cleanup service destruction Stanislav Kinsbursky
2011-10-27 21:30 ` J. Bruce Fields
2011-10-28 9:49 ` Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 6/8] NFSd: call svc rpcbind cleanup explicitly Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 7/8] SUNRPC: remove rpcbind clients creation during service registering Stanislav Kinsbursky
2011-10-25 11:17 ` [PATCH v6 8/8] SUNRPC: remove rpcbind clients destruction on module cleanup Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAA7565.1040101@parallels.com \
--to=skinsbursky@parallels$(echo .)com \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=bfields@fieldses$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox