Subject: Re: [PATCH 0/2] clean up tx_bytes accounting

From: Oliver Hartkopp <[email-masked]>
Date: Thu, 03 Nov 2011 15:27:38 +0100

On 03.11.2011 11:42, Marc Kleine-Budde wrote:

> On 11/03/2011 11:03 AM, Kurt Van Dijck wrote:
>> On Thu, Nov 03, 2011 at 10:47:53AM +0100, Marc Kleine-Budde wrote:
>>> Hello,
>>>
>>> what about turning can_get_echo_skb() into a helper function which returns the number
>>> of tx'ed bytes.
>> That would work.
>>
>> Next step would be to do the statistics inside can_get_echo_skb(), but that's
>> affecting all drivers using it ...
>> Kurt
> 
> Interesting idea

Yes, but then the name of the function is not appropriate anymore.

The return value for can_get_echo_skb() gives a silent improvement that can be
adopted by CAN drivers by the time. But hiding more functionality inside this
function may lead to misunderstandings.

Regards,
Oliver