From: Mark Lord <kernel@teksavvy•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] drivers/net/usb/asix: resync from vendor's copy
Date: Wed, 09 Nov 2011 11:57:14 -0500 [thread overview]
Message-ID: <4EBAB0EA.1050102@teksavvy.com> (raw)
In-Reply-To: <4EBAAEA5.1060408@teksavvy.com>
On 11-11-09 11:47 AM, Mark Lord wrote:
..
> Note: I'm looking at smsc95xx.c and smsc75xx.c for examples,
> and they both have the same problem I'll have here:
>
> How to update the csum settings atomically.
> A spinlock is no good, because config register access is over USB.
Nevermind.. a slight change in the logic and all is well again.
static int ax88772b_set_features(struct net_device *netdev, u32 features)
{
struct usbnet *dev = netdev_priv(netdev);
struct ax88772b_data *priv = (struct ax88772b_data *)dev->driver_priv;
unsigned long flags;
u16 tx_csum = 0, rx_csum = 0;
spin_lock_irqsave(&priv->features_lock, flags);
if (features & NETIF_F_HW_CSUM) {
priv->checksum |= AX_TX_CHECKSUM;
tx_csum = AX_TXCOE_DEF_CSUM;
} else
priv->checksum &= ~AX_TX_CHECKSUM;
if (features & NETIF_F_RXCSUM) {
priv->checksum |= AX_RX_CHECKSUM;
rx_csum = AX_RXCOE_DEF_CSUM;
} else
priv->checksum &= ~AX_RX_CHECKSUM;
spin_unlock_irqrestore(&priv->features_lock, flags);
ax8817x_write_cmd(dev, AX_CMD_WRITE_RXCOE_CTL,
rx_csum, 0, 0, NULL);
ax8817x_write_cmd(dev, AX_CMD_WRITE_TXCOE_CTL,
tx_csum, 0, 0, NULL);
return 0;
}
next prev parent reply other threads:[~2011-11-09 16:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 23:36 asix usb network driver: nfg Mark Lord
2011-10-26 23:40 ` David Miller
2011-10-27 1:23 ` Mark Lord
2011-10-27 2:17 ` David Miller
2011-10-27 18:48 ` Mark Lord
2011-11-02 19:36 ` [PATCH] drivers/net/usb/asix: resync from vendor's copy Mark Lord
2011-11-02 19:48 ` Mark Lord
2011-11-02 20:42 ` Ben Hutchings
2011-11-02 22:44 ` Mark Lord
2011-11-09 16:25 ` Mark Lord
2011-11-09 16:34 ` Ben Hutchings
2011-11-09 16:47 ` Mark Lord
2011-11-09 16:57 ` Mark Lord [this message]
2011-11-09 17:20 ` Mark Lord
2011-11-09 17:31 ` Ben Hutchings
2011-11-09 17:40 ` Mark Lord
2011-11-09 17:48 ` Ben Hutchings
2011-11-09 18:22 ` Mark Lord
2011-12-05 14:41 ` Mark Lord
2011-12-05 15:18 ` Ben Hutchings
2011-12-06 12:44 ` Mark Lord
2011-12-06 17:45 ` Ben Hutchings
2011-12-07 16:21 ` Mark Lord
2011-12-07 16:27 ` Ben Hutchings
2011-12-07 16:59 ` Mark Lord
2011-12-07 17:03 ` Ben Hutchings
2011-11-07 16:09 ` Michal Marek
2011-11-09 17:31 ` [PATCH v2] " Mark Lord
2011-11-09 17:41 ` Mark Lord
2011-11-09 17:43 ` Mark Lord
2011-11-09 17:47 ` Ben Hutchings
2011-11-09 18:27 ` Mark Lord
2011-11-09 17:49 ` [PATCH v3] " Mark Lord
2011-11-10 14:01 ` [PATCH v2] " Mark Lord
2011-11-10 16:54 ` Grant Grundler
2011-11-10 20:17 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBAB0EA.1050102@teksavvy.com \
--to=kernel@teksavvy$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox