public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger•com>
To: Netdev@vger•kernel.org
Cc: linux-can@vger•kernel.org, Socketcan-core@lists•berlios.de,
	Marc Kleine-Budde <mkl@pengutronix•de>
Subject: net/can/mscan: Fix buggy listen only mode setting
Date: Mon, 14 Nov 2011 14:34:56 +0100	[thread overview]
Message-ID: <4EC11900.7030005@grandegger.com> (raw)

This patch fixes an issue introduced recently with commit
452448f9283e1939408b397e87974a418825b0a8.

CC: Marc Kleine-Budde <mkl@pengutronix•de>
Signed-off-by: Wolfgang Grandegger <wg@grandegger•com>
---
 drivers/net/can/mscan/mscan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index 74f3b18..1c82dd8 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -581,7 +581,7 @@ static int mscan_open(struct net_device *dev)
 
 	priv->open_time = jiffies;
 
-	if (ctrlmode.flags & CAN_CTRLMODE_LISTENONLY)
+	if (priv->can.ctrlmode & CAN_CTRLMODE_LISTENONLY)
 		setbits8(&regs->canctl1, MSCAN_LISTEN);
 	else
 		clrbits8(&regs->canctl1, MSCAN_LISTEN);
-- 
1.7.6.4

             reply	other threads:[~2011-11-14 13:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 13:34 Wolfgang Grandegger [this message]
     [not found] ` <4EC11900.7030005-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-11-14 19:30   ` net/can/mscan: Fix buggy listen only mode setting David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC11900.7030005@grandegger.com \
    --to=wg@grandegger$(echo .)com \
    --cc=Netdev@vger$(echo .)kernel.org \
    --cc=Socketcan-core@lists$(echo .)berlios.de \
    --cc=linux-can@vger$(echo .)kernel.org \
    --cc=mkl@pengutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox