Subject: Re: [PATCH] bonding: Don't allow mode change via sysfs with slaves present

From: Nicolas de Pesloüan<[email-masked]>
Date: Tue, 15 Nov 2011 20:24:29 +0100

Le 15/11/2011 18:00, Andy Gospodarek a écrit :
> On Tue, Nov 15, 2011 at 05:44:42PM +0100, Veaceslav Falico wrote:
>> When changing mode via bonding's sysfs, the slaves are not initialized
>> correctly. Forbid to change modes with slaves present to ensure that every
>> slave is initialized correctly via bond_enslave().
>>
>> Signed-off-by: Veaceslav Falico<[email-masked]>
>
> Looks good.  This behavior forces someone who wants to change to mode to
> go through steps that are almost as destructive as when module options
> are used to configure the mode.  I do not see a problem with this.

Except the fact that is enforce one more constraint on the exact order one should write into sysfs 
to setup a bonding interface. We already have many such constraints and probably don't need more.

Currently, it is possible to enslave slaves before selecting the mode. The ifenslave-2.6 package 
from Debian currently enslave slaves before setting the mode and would break with this change.

NAK.

	Nicolas.