Subject: Re: [net-next PATCH] net: netprio_cgroup: make net_prio_subsys static

From: John Fastabend <[email-masked]>
Date: Fri, 09 Dec 2011 08:31:59 -0800

On 12/9/2011 8:05 AM, Eric Dumazet wrote:
> Le jeudi 08 décembre 2011 à 19:53 -0500, David Miller a écrit :
>> From: Neil Horman <[email-masked]>
>> Date: Thu, 8 Dec 2011 06:45:55 -0500
>>
>>> On Wed, Dec 07, 2011 at 09:17:17PM -0800, John Fastabend wrote:
>>>> net_prio_subsys can be made static this removes the sparse
>>>> warning it was throwing.
>>>>
>>>> Signed-off-by: John Fastabend <[email-masked]>
>>  ...
>>> Acked-by: Neil Horman <[email-masked]>
>>
>> Applied.
>> --
> 
> But it trivialy breaks the build ? Or am I mistaken ?
> 

Dang. No your right. When its not built as a module it breaks. Sorry
I'll revert it.

> 
> $ grep CONFIG_NETPRIO_CGROUP .config
> CONFIG_NETPRIO_CGROUP=y
> 
> $ make net/core/netprio_cgroup.o
>   CC      net/core/netprio_cgroup.o
> net/core/netprio_cgroup.c:31:29: error: static declaration of ‘net_prio_subsys’ follows non-static declaration
> include/linux/cgroup_subsys.h:71:1: note: previous declaration of ‘net_prio_subsys’ was here
> make[1]: *** [net/core/netprio_cgroup.o] Error 1
> make: *** [net/core/netprio_cgroup.o] Error 2
> 
> 
>