From: Dimitris Michailidis <dm@chelsio•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-net-drivers@solarflare•com,
Matt Carlson <mcarlson@broadcom•com>,
Eilon Greenstein <eilong@broadcom•com>,
Shreyas Bhatewara <sbhatewara@vmware•com>,
"VMware, Inc." <pv-drivers@vmware•com>
Subject: Re: [PATCH net-next 2/3] ethtool: Centralise validation of ETHTOOL_{G,S}RXFHINDIR parameters
Date: Thu, 15 Dec 2011 16:51:31 -0800 [thread overview]
Message-ID: <4EEA9613.7090501@chelsio.com> (raw)
In-Reply-To: <1323993301.2773.26.camel@bwh-desktop>
On 12/15/2011 03:55 PM, Ben Hutchings wrote:
> Add a new ethtool operation (get_rxfh_indir_size) to get the
> indirectional table size. Use this to validate the user buffer size
> before calling get_rxfh_indir or set_rxfh_indir. Use get_rxnfc to get
> the number of RX rings, and validate the contents of the new
> indirection table before calling set_rxfh_indir. Remove this
> validation from drivers.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare•com>
> ---
> The bnx2x, cxgb4 and vmxnet3 changes are compile-tested only.
The cxgb4 and core changes look good.
Acked-by: Dimitris Michailidis <dm@chelsio•com>
next prev parent reply other threads:[~2011-12-16 0:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 23:51 [PATCH net-next 1/3] ethtool: Clarify use of size field for ETHTOOL_GRXFHINDIR Ben Hutchings
2011-12-15 23:55 ` [PATCH net-next 2/3] ethtool: Centralise validation of ETHTOOL_{G,S}RXFHINDIR parameters Ben Hutchings
2011-12-16 0:51 ` Dimitris Michailidis [this message]
2011-12-16 18:53 ` David Miller
2011-12-15 23:56 ` [PATCH net-next 3/3] ethtool: Define and apply a default policy for RX flow hash indirection Ben Hutchings
2011-12-16 3:38 ` Shreyas Bhatewara
2011-12-16 18:54 ` David Miller
2011-12-16 1:14 ` [PATCH net-next 1/3] ethtool: Clarify use of size field for ETHTOOL_GRXFHINDIR Matt Carlson
2011-12-16 18:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA9613.7090501@chelsio.com \
--to=dm@chelsio$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eilong@broadcom$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=mcarlson@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pv-drivers@vmware$(echo .)com \
--cc=sbhatewara@vmware$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox