From: Koki Sanagi <sanagi.koki@jp•fujitsu.com>
To: "Wyborny, Carolyn" <carolyn.wyborny@intel•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel•com>,
"Allan, Bruce W" <bruce.w.allan@intel•com>,
"Skidmore, Donald C" <donald.c.skidmore@intel•com>,
"Rose, Gregory V" <gregory.v.rose@intel•com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel•com>,
"Duyck, Alexander H" <alexander.h.duyck@intel•com>,
"Ronciak, John" <john.ronciak@intel•com>,
"e1000-devel@lists•sourceforge.net"
<e1000-devel@lists•sourceforge.net>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: Re: [PATCH net-next] igb: reset PHY after recovering from PHY power down
Date: Mon, 19 Dec 2011 08:59:28 +0900 [thread overview]
Message-ID: <4EEE7E60.5030000@jp.fujitsu.com> (raw)
In-Reply-To: <9BBC4E0CF881AA4299206E2E1412B626C0CF@ORSMSX102.amr.corp.intel.com>
(2011/12/17 0:53), Wyborny, Carolyn wrote:
>
>
>> -----Original Message-----
>> From: Koki Sanagi [mailto:sanagi.koki@jp•fujitsu.com]
>> Sent: Wednesday, November 23, 2011 7:18 PM
>> To: netdev@vger•kernel.org; Kirsher, Jeffrey T; Brandeburg, Jesse;
>> Allan, Bruce W; Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V;
>> Waskiewicz Jr, Peter P; Duyck, Alexander H; Ronciak, John; e1000-
>> devel@lists•sourceforge.net
>> Cc: davem@davemloft•net
>> Subject: [PATCH net-next] igb: reset PHY after recovering from PHY power
>> down
>>
>> According to 82576_Datasheet.pdf, PHY setting is lost after PHY power
>> down.
>> So resetting PHY is needed when recovering from PHY power down to set a
>> default
>> setting to PHY register.
>>
>> Owing to this lack, NIC doesn't link up in some rare situation.
>> The situation I encountered is following.
>>
>>
>> 1.Both ports connect to switch.
>> +---------+ +--------+
>> | |-----------| |
>> | 82576NS | | switch |
>> | |-----------| |
>> +---------+ +--------+
>>
>> 2.Detach both cables from switch.
>> +---------+ +--------+
>> | |------- | |
>> | 82576NS | | switch |
>> | |------- | |
>> +---------+ +--------+
>>
>> 3.Detach one cable from one port.
>> +---------+ +--------+
>> | |------- | |
>> | 82576NS | | switch |
>> | | | |
>> +---------+ +--------+
>>
>> 4.Attach that cable to the other port.(It means connecting directly each
>> port)
>> +---------+ +--------+
>> | |-------+ | |
>> | 82576NS | | | switch |
>> | |-------+ | |
>> +---------+ +--------+
>>
>> As a result, NIC doesn't link up sometimes.
>>
>> Signed-off-by: Koki Sanagi <sanagi.koki@jp•fujitsu.com>
>> ---
>> drivers/net/ethernet/intel/igb/igb_main.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
>> b/drivers/net/ethernet/intel/igb/igb_main.c
>> index bd9b30e..4d4f065 100644
>> --- a/drivers/net/ethernet/intel/igb/igb_main.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
>> @@ -2496,6 +2496,7 @@ static int igb_open(struct net_device *netdev)
>> goto err_setup_rx;
>>
>> igb_power_up_link(adapter);
>> + igb_reset_phy(hw);
>>
>> /* before we allocate an interrupt, we must be ready to handle it.
>> * Setting DEBUG_SHIRQ in the kernel makes it fire an interrupt
>
> I apologize for the delay in getting back to you. After a review, I see
> that the needed change is simpler than I thought at first. Can you resubmit
> with the igb_reset_phy call being added to the end of the igb_power_up_link
> function instead of after it in igb_open. That way, whenever igb_power_link
> is called in the code, it will also execute the igb_reset_phy function which
> is the complete solution. Thank you for your work on the igb driver.
>
Thank you for your reply.
O.K. I'll resubmit it soon.
Thanks!
Koki Sanagi
> Carolyn
>
> Carolyn Wyborny
> Linux Development
> LAN Access Division
> Intel Corporation
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2011-12-19 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 3:18 [PATCH net-next] igb: reset PHY after recovering from PHY power down Koki Sanagi
2011-11-28 17:57 ` Wyborny, Carolyn
2011-12-14 5:55 ` Koki Sanagi
2011-12-16 15:53 ` Wyborny, Carolyn
2011-12-18 23:59 ` Koki Sanagi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEE7E60.5030000@jp.fujitsu.com \
--to=sanagi.koki@jp$(echo .)fujitsu.com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox