public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Wang Xingtong <wangxingtong@cn•fujitsu.com>
To: netdev@vger•kernel.org
Cc: davem@davemloft•net
Subject: [PATCH] IPv6 : add multicast routing verify which net_device is lo
Date: Tue, 20 Dec 2011 14:13:46 +0800	[thread overview]
Message-ID: <4EF0279A.30800@cn.fujitsu.com> (raw)

In currently routing subsystem, when we lookup a multicast routing
to send muticast packets to outside, rt6_device_match will return
the rt6_info which it's match first. if we add a multicast route on
loopback devices beforce the others interface, rt6_device_match will
retrun the rt6_info which rt6i_dev->name is "lo". But, obviously,
we can't send a muticast packet to outside using loopback devices.
It case all multicast packets blocking.

Commit 4af04aba93f47699e disabled kernel add multicast route on lo
automatically. However,  we can't surmise the routing-add order or
interdict add multicast routing on loopback devices in user space.
The bug still exist. So, i think more stronger routing subsystem is
necessary.

Signed-off-by: Wang xingtong <wangxingtong@cn•fujitsu.com>

---
  net/ipv6/route.c |   19 ++++++++++++++++---
  1 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index b582a0a..3871ef4 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -334,9 +334,16 @@ static inline struct rt6_info 
*rt6_device_match(struct net *net,
      struct rt6_info *local = NULL;
      struct rt6_info *sprt;

-    if (!oif && ipv6_addr_any(saddr))
+    if (!oif && ipv6_addr_any(saddr)){
+        if (unlikely(rt->rt6i_dev->flags & IFF_LOOPBACK &&
+            ipv6_addr_is_multicast(&rt->rt6i_dst.addr))){
+            rt=rt->dst.rt6_next;
+            goto match;
+        }
          goto out;
+    }

+match:
      for (sprt = rt; sprt; sprt = sprt->dst.rt6_next) {
          struct net_device *dev = sprt->rt6i_dev;

@@ -355,9 +362,15 @@ static inline struct rt6_info 
*rt6_device_match(struct net *net,
                  local = sprt;
              }
          } else {
-            if (ipv6_chk_addr(net, saddr, dev,
-                      flags & RT6_LOOKUP_F_IFACE))
+            if (ipv6_addr_any(saddr)){
+                if (unlikely(rt->rt6i_dev->flags & IFF_LOOPBACK &&
+                    ipv6_addr_is_multicast(&rt->rt6i_dst.addr))){
+                    continue;
                  return sprt;
+            }
+            else if (ipv6_chk_addr(net, saddr, dev,
+                      flags & RT6_LOOKUP_F_IFACE))
+                    return sprt;
          }
      }

-- 
1.7.1

next             reply	other threads:[~2011-12-20  6:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  6:13 Wang Xingtong [this message]
2011-12-20  9:47 ` [PATCH] IPv6 : add multicast routing verify which net_device is lo Wang Xingtong
2011-12-20 11:10   ` [PATCH V2] " Gao feng
2011-12-21  6:15     ` David Miller
2011-12-21  9:01       ` Wang Xingtong
2011-12-21 19:11         ` David Miller

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:b582a0a dfblob:3871ef4 )
 OR (
bs:"[PATCH] IPv6 : add multicast routing verify which net_device is lo" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF0279A.30800@cn.fujitsu.com \
    --to=wangxingtong@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox