Subject: Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit

From: Maxim Uvarov <[email-masked]>
Date: Mon, 09 Jan 2012 19:09:32 -0800

On 01/09/2012 02:20 PM, Andy Gospodarek wrote:
> On Mon, Jan 09, 2012 at 02:01:37PM -0800, Maxim Uvarov wrote:
>> No need to lock soft irqs under bond_alb_xmit()
>> which already has softirq disabled.
>>
>> Changes:
>> 1. add non-bh/bh version to tlb_clear_slave()
>>
>> 2. represent BH and non BH hash table locks
>> _lock_rx_hashtbl_bh/_unlock_rx_hashtbl_bh
>> _lock_rx_hashtbl/_unlock_rx_hashtbl
>> _lock_tx_hashtbl_bh/_unlock_tx_hashtbl_bh
>> _lock_tx_hashtbl/_unlock_tx_hashtbl
>>
>> Signed-off-by: Maxim Uvarov<[email-masked]>
>> Signed-off-by: Cong Wang<[email-masked]>
>> ---
>>   drivers/net/bonding/bond_alb.c |  112 +++++++++++++++++++++++++++-------------
>>   1 files changed, 76 insertions(+), 36 deletions(-)
>>
>
> Did you test this with CONFIG_DEBUG_LOCKDEP=y at all?
>

Just did some simple tests on bond0 with LOCKDEP. Do not see any warnings.

Maxim.