From: Stanislav Kinsbursky <skinsbursky@parallels•com>
To: "J. Bruce Fields" <bfields@fieldses•org>
Cc: "Trond.Myklebust@netapp•com" <Trond.Myklebust@netapp•com>,
"linux-nfs@vger•kernel.org" <linux-nfs@vger•kernel.org>,
Pavel Emelianov <xemul@parallels•com>,
"neilb@suse•de" <neilb@suse•de>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
James Bottomley <jbottomley@parallels•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"devel@openvz•org" <devel@openvz•org>
Subject: Re: [PATCH 3/4] SUNRPC: service destruction in network namespace context
Date: Fri, 27 Jan 2012 19:21:18 +0400 [thread overview]
Message-ID: <4F22C0EE.4090701@parallels.com> (raw)
In-Reply-To: <20120127143335.GB9439@fieldses.org>
27.01.2012 18:33, J. Bruce Fields пишет:
> OK, so at this point svc_close_net(serv, current->nsproxy->net_ns) is
> enough to clear out sv_permsocks and sv_temp_socks because we know that
> the only sockets left are in that namespace. Got it.
>
BTW, is this approach looks suitable for NFSd service?
> I'm not sure. The one thing that might have helped mere here would be
> a comment to explain what's going on, maybe something like:
>
> svc_close_net(serv, net);
> + /*
> + * The last user is gone, so the only sockets left belonged its
> + * network namespace:
> + */
> BUG_ON(!list_empty(&serv->sv_permsocks));
> BUG_ON(!list_empty(&serv->sv_tempsocks));
Ok, can do so.
--
Best regards,
Stanislav Kinsbursky
next prev parent reply other threads:[~2012-01-27 15:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 13:47 [PATCH 0/4] SUNRPC: service release in network namespace context Stanislav Kinsbursky
2012-01-25 13:47 ` [PATCH 1/4] SUNRPC: clear svc pools lists helper introduced Stanislav Kinsbursky
2012-01-25 13:47 ` [PATCH 2/4] SUNRPC: clear svc transports " Stanislav Kinsbursky
2012-01-25 13:47 ` [PATCH 3/4] SUNRPC: service destruction in network namespace context Stanislav Kinsbursky
[not found] ` <20120125134726.13662.97179.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-26 21:14 ` J. Bruce Fields
2012-01-27 9:08 ` Stanislav Kinsbursky
2012-01-27 14:33 ` J. Bruce Fields
2012-01-27 15:21 ` Stanislav Kinsbursky [this message]
2012-01-25 13:47 ` [PATCH 4/4] SUNRPC: service shutdown function in network namespace context introduced Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F22C0EE.4090701@parallels.com \
--to=skinsbursky@parallels$(echo .)com \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=bfields@fieldses$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=jbottomley@parallels$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox