From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] ipv6: fix RFC5722 comment
Date: Mon, 30 Jan 2012 15:42:25 +0100 [thread overview]
Message-ID: <4F26AC51.8080108@6wind.com> (raw)
In-Reply-To: <1327933764.2288.42.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Le 30/01/2012 15:29, Eric Dumazet a écrit :
> RFC5722 Section 4 was amended by Errata 3089
>
> Our implementation did the right thing anyway...
>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail•com>
> Cc: Nicolas Dichtel<nicolas.dichtel@6wind•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
> net/ipv6/reassembly.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
> index b69fae7..9447bd6 100644
> --- a/net/ipv6/reassembly.c
> +++ b/net/ipv6/reassembly.c
> @@ -336,12 +336,11 @@ static int ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
> }
>
> found:
> - /* RFC5722, Section 4:
> - * When reassembling an IPv6 datagram, if
> + /* RFC5722, Section 4, amended by Errata ID : 3089
> + * When reassembling an IPv6 datagram, if
Identation was an exact copy of the original rfc (not changed by the errata),
but it's a detail ;-)
Regards,
Nicolas
> * one or more its constituent fragments is determined to be an
> * overlapping fragment, the entire datagram (and any constituent
> - * fragments, including those not yet received) MUST be silently
> - * discarded.
> + * fragments) MUST be silently discarded.
> */
>
> /* Check for overlap with preceding fragment. */
next prev parent reply other threads:[~2012-01-30 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 14:29 [PATCH net-next] ipv6: fix RFC5722 comment Eric Dumazet
2012-01-30 14:42 ` Nicolas Dichtel [this message]
2012-01-30 17:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F26AC51.8080108@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox