Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

From: Ben Greear <[email-masked]>
Date: Sat, 04 Feb 2012 17:52:45 -0800

On 02/04/2012 01:26 PM, David Miller wrote:
> From: Shawn Lu<[email-masked]>
> Date: Sat, 4 Feb 2012 13:22:36 -0800
>
>> +	/*
>> +	 * When socket is gone, all binding information is lost.
>> +	 * routing might fail in this case. using iif for oif to
>> +	 * make sure we can deliver it
>> +	 */
>
> Comment is poorly formatted, and I'm getting tired of teaching
> people
>
> 	/* That comments are formatted like
> 	 * this.
> 	 */
>
> 	/*
> 	 * Not like this.
> 	 */

I agree with your taste in comments, but the linux style guide
says basically the opposite.  Maybe see if you can sneak a patch
into the style guide? :)

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com