From: Pavel Emelyanov <xemul@parallels•com>
To: Anisse Astier <anisse@astier•eu>
Cc: David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.
Date: Tue, 07 Feb 2012 17:37:51 +0400 [thread overview]
Message-ID: <4F31292F.2090503@parallels.com> (raw)
In-Reply-To: <20120207121256.50667809@destiny.ordissimo>
>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> index 1a8f93b..43e1439 100644
>> --- a/net/ipv4/Kconfig
>> +++ b/net/ipv4/Kconfig
>> @@ -410,8 +410,12 @@ config INET_TCP_DIAG
>> def_tristate INET_DIAG
>>
>> config INET_UDP_DIAG
>> + tristate "UDP: socket monitoring interface"
>> depends on INET_DIAG
>> - def_tristate INET_DIAG && IPV6
> This broke earlier patch
> b872a2371ffd13e6d83423ef621a707df4c158ac "udp_diag: Make it module when ipv6 is a module",
> which brings back the compilation error when compiling linus master (v3.3-rc2+):
>
> net/built-in.o: In function `udp_dump_one':
> udp_diag.c:(.text+0x59852): undefined reference to `__udp6_lib_lookup'
>
>
>> + default n
>> + ---help---
>> + Support for UDP socket monitoring interface used by the ss tool.
>> + If unsure, say Y.
>>
I assume you have CONFIG_IPV6=m and CONFIG_INET_UDP_DIAG=y, right?
This one should fix the issue, you'll not be able to set it to Y when
IPV6 is M.
[PATCH] udp_diag: Add dependency on IPV6
Signed-off-by: Pavel Emelyanov <xemul@parallels•com>
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index aa2a2c7..55d39a4 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -409,7 +409,7 @@ config INET_TCP_DIAG
config INET_UDP_DIAG
tristate "UDP: socket monitoring interface"
- depends on INET_DIAG
+ depends on INET_DIAG && IPV6
default n
---help---
Support for UDP socket monitoring interface used by the ss tool.
next prev parent reply other threads:[~2012-02-07 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 20:13 [PATCH] net: Default UDP and UNIX diag to 'n' David Miller
2012-02-07 11:12 ` Anisse Astier
2012-02-07 13:37 ` Pavel Emelyanov [this message]
2012-02-07 13:51 ` Anisse Astier
2012-02-07 17:29 ` David Miller
2012-02-07 17:29 ` David Miller
2012-02-07 17:39 ` Anisse Astier
2012-02-07 18:36 ` David Miller
2012-02-07 21:01 ` Anisse Astier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F31292F.2090503@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=anisse@astier$(echo .)eu \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox