Subject: Re: [PATCH 1/2] stmmac: request_irq when use an ext wake irq line

From: Giuseppe CAVALLARO <[email-masked]>
Date: Fri, 10 Feb 2012 07:31:21 +0100

On 2/9/2012 8:02 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <[email-masked]>
> Date: Thu,  9 Feb 2012 08:55:13 +0100
> 
>> From: Francesco Virlinzi <[email-masked]>
>>
>> In case of we use an external Wake-Up IRQ line
>> (priv->wol_irq != dev->irq) we need to invoke the
>> request_irq.
>>
>> Signed-off-by: Francesco Virlinzi <[email-masked]>
>> Signed-off-by: Giuseppe Cavallaro <[email-masked]>
> 
> You never free the IRQ in the driver close path, so it leaks.

Yes you are right. I'm reviewing the patch and send it again.
Thx
peppe

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>