From: Li Wei <lw@cn•fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] ipv4: Fix wrong order of ip_rt_get_source() and update iph->daddr.
Date: Fri, 10 Feb 2012 15:08:10 +0800 [thread overview]
Message-ID: <4F34C25A.4020904@cn.fujitsu.com> (raw)
In-Reply-To: <1328857450.2436.9.camel@edumazet-laptop>
Eric Dumazet 写道:
> Le vendredi 10 février 2012 à 14:48 +0800, Li Wei a écrit :
>> Need to update iph->daddr before ip_rt_get_source(), otherwise
>> we may get a wrong src.
>>
>
> It would be nice that patch submitters try to pinpoint bug origin in
> changelog, to ease patch review and stable submissions.
>
> Is it coming from ac8a48106be49c422575ddc7531b776f8eb49610 (ipv4: Save
> nexthop address of LSRR/SSRR option to IPCB.) added in 3.2, or is it
> something needing a backport in some other way in old kernels ?
As you said, it is coming from ac8a48106be49c422575ddc7531b776f8eb49610
(ipv4: Save nexthop address of LSRR/SSRR option to IPCB.).
I'll modify the changelog and post a v2.
Thanks!
>
> Thanks !
>
>
>
>
next prev parent reply other threads:[~2012-02-10 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 6:48 [PATCH] ipv4: Fix wrong order of ip_rt_get_source() and update iph->daddr Li Wei
2012-02-10 7:04 ` Eric Dumazet
2012-02-10 7:08 ` Li Wei [this message]
2012-02-10 7:34 ` Li Wei
2012-02-10 7:15 ` [PATCH v2] " Li Wei
2012-02-10 20:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F34C25A.4020904@cn.fujitsu.com \
--to=lw@cn$(echo .)fujitsu.com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox