Subject: Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

From: Ben Greear <[email-masked]>
Date: Mon, 13 Feb 2012 09:19:33 -0800

On 02/11/2012 09:07 AM, Eric Dumazet wrote:
> Le vendredi 10 février 2012 à 17:04 -0800, [email-masked] a
> écrit :
>> From: Ben Greear<[email-masked]>
>>
>> This allows e100 to be configured to append the
>> Ethernet FCS to the skb.
>>
>> Useful for sniffing networks.
>>
>> Signed-off-by: Ben Greear<[email-masked]>
>> ---
>
> Did you try this patch with 8021Q frames ?
>
> You must change
>
> #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN)
>
> to :
>
> #define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)
>
> And also on various spots where VLAN_ETH_FRAME_LEN is used in this
> driver...
>
> nic->blank_rfd.size = cpu_to_le16(VLAN_ETH_FRAME_LEN);

Thanks for the review.  I did not try it with VLAN frames.  It may
be a few days until I can get this done and test it well....

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com