From: Chris Friesen <chris.friesen@genband•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Jay Vosburgh <fubar@us•ibm.com>,
andy@greyhouse•net, netdev <netdev@vger•kernel.org>
Subject: Re: [BUG?] bonding, slave selection, carrier loss, etc.
Date: Mon, 13 Feb 2012 12:16:59 -0600 [thread overview]
Message-ID: <4F39539B.5060507@genband.com> (raw)
In-Reply-To: <1328986371.325.7.camel@deadeye>
On 02/11/2012 12:52 PM, Ben Hutchings wrote:
> On Fri, 2012-02-10 at 17:53 -0800, Jay Vosburgh wrote:
>> Chris Friesen<chris.friesen@genband•com> wrote:
>>> The best solution would be for bonding to just register for notification
>>> of the link going down. Presumably most drivers should be doing that
>>> properly by now, and for devices that get interrupt-driven notification
>>> of link status changes this would allow the bonding code to react much
>>> quicker.
>>
>> A quick look at some drivers shows that at least acenic still
>> doesn't do netif_carrier_off, so converting entirely to a notifier-based
>> failover mechanism would break drivers that work today.
> [...]
>
> It might be worth having some sort of feature flag (in priv_flags) that
> indicates whether the driver updates the link state. Alternately,
> disable polling of a device once you see a notification.
This makes a lot of sense to me...it is suboptimal to still be polling
when most people that care about bonding reliability are going to be
using ethernet hardware with interrupt-based link change notification.
Chris
--
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband•com
www.genband.com
next prev parent reply other threads:[~2012-02-13 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49CD5B93.7010407@nortel.com>
[not found] ` <31087.1238198438@death.nxdomain.ibm.com>
2012-02-10 23:47 ` [BUG?] bonding, slave selection, carrier loss, etc Chris Friesen
2012-02-11 1:53 ` Jay Vosburgh
2012-02-11 18:52 ` Ben Hutchings
2012-02-13 18:16 ` Chris Friesen [this message]
2012-02-13 18:48 ` Stephen Hemminger
2012-02-13 19:18 ` Chris Friesen
2012-02-13 20:24 ` Ben Hutchings
2012-02-13 20:37 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F39539B.5060507@genband.com \
--to=chris.friesen@genband$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=bhutchings@solarflare$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox