From: Divy Le Ray <divy@chelsio•com>
To: David Woodhouse <dwmw2@infradead•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Steve Wise <swise@opengridcomputing•com>,
nhorman@tuxdriver•com
Subject: Re: [patch net-next] cxgb3: update firmware version
Date: Mon, 13 Feb 2012 13:39:15 -0800 [thread overview]
Message-ID: <4F398303.1030606@chelsio.com> (raw)
In-Reply-To: <1329165817.2092.62.camel@shinybook.infradead.org>
On Monday, February 13, 2012 12:43:37 PM, David Woodhouse wrote:
>
> On Mon, 2012-02-13 at 12:28 -0800, Divy Le Ray wrote:
>>
>> This patch updates the firmware version cxgb3 is requesting to 7.12.0.
>
>
> I'm confused. Your patch doesn't change anything in the driver, except
> the firmware version. So why is it a "major" change?
Hi David,
cxgb3 embeds the firmware file name it will request at load time.
It uses the FW_VERSION_* defs to construct the firmware name FW_FNAME
before calling request_firmware().
Hence the need to update the firmware minor version.
On the other hand, the driver version update is not a strict requirement
here.
I would prefer keeping it though.
Cheers,
Divy
next prev parent reply other threads:[~2012-02-13 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 20:28 [patch net-next] cxgb3: update firmware version Divy Le Ray
2012-02-13 20:43 ` David Woodhouse
2012-02-13 21:39 ` Divy Le Ray [this message]
2012-02-14 1:59 ` Ben Hutchings
2012-02-14 4:49 ` Divy Le Ray
2012-02-14 5:08 ` Ben Hutchings
2012-02-14 5:55 ` Divy Le Ray
2012-02-14 18:17 ` Rick Jones
2012-02-14 18:21 ` Ben Hutchings
2012-02-14 20:02 ` Rick Jones
2012-02-14 22:02 ` Ben Hutchings
2012-02-15 20:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F398303.1030606@chelsio.com \
--to=divy@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=swise@opengridcomputing$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox