From: Ben Greear <greearb@candelatech•com>
To: netdev <netdev@vger•kernel.org>,
e1000-devel list <e1000-devel@lists•sourceforge.net>
Subject: rx-over-length stats problem with e100
Date: Wed, 15 Feb 2012 16:57:53 -0800 [thread overview]
Message-ID: <4F3C5491.7090600@candelatech.com> (raw)
While testing my rx-all patches, I triggered a code branch
that caused the rx_over_length_errors counter to increment
in the e100_rx_indicate path (it can already increment there
w/out my patch, it appears).
The problem is that then the stats go weird because the code in
e100_update_stats adds the total rx_over_length_errors each time
it's called, and does not reset the rx_over_length_errors to zero:
ns->rx_length_errors += le32_to_cpu(s->rx_short_frame_errors) +
nic->rx_over_length_errors;
So, should we zero out that counter after reading it (although that
might race)? Any idea how this is supposed to work?
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
reply other threads:[~2012-02-16 0:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3C5491.7090600@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox