From: Knut Petersen <Knut_Petersen@t-online•de>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: netdev@vger•kernel.org, dilieto@lineone•net,
Mirko Lindner <mlindner@syskonnect•de>,
Ralph Roesler <rroesler@syskonnect•de>,
arekm@maven•pl, nitro@legroom•net, Andrew Morton <akpm@osdl•org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [REGRESSION, PATCH] sky2 WOL fix
Date: Fri, 17 Feb 2012 19:21:53 +0100 [thread overview]
Message-ID: <4F3E9AC1.6060704@t-online.de> (raw)
In-Reply-To: <20120215091622.429fe9c3@nehalam.linuxnetplumber.net>
Am 15.02.2012 18:16, schrieb Stephen Hemminger:
> On Tue, 14 Feb 2012 09:25:02 +0100
> Knut Petersen<Knut_Petersen@t-online•de> wrote:
>
>> From f3a7086638b0ee1f9d9e9028a188d96646671088 Mon Sep 17 00:00:00 2001
>> From: Knut Petersen<Knut_Petersen@t-online•de>
>> Date: Tue, 14 Feb 2012 08:35:17 +0100
>> Subject: [PATCH] Fix an old sky2 WOL regression
>>
>> Wake-On-Lan was broken for a few systems with commit
>> 87b09f1f25cd1e01d7c50bf423c7fe33027d7511 more than a
>> year ago.
>>
>> This commit fixes the regression for the AOpen i915GMm-HFS
>> motherboard. It reintroduces the old code, but that code is
>> only executed for those system included in a dmi_system_id
>> list. Currently there is only one entry in that list, but
>> it probably will grow.
>>
>> Signed-off-by: Knut Petersen<Knut_Petersen@t-online•de>
> You might also want to check with AOpen to see if there is a BIOS
> update. Often the BIOS programs bits on the onboard card to deal
> with power management issues.
>
[I added some people to the cc list that commented on bug #19492]
The last BIOS AOpen published for that board is more than six years old.
No. I will not bother them with this problem.
Your commit broke existing support for WOL on a number of boards.
This is known to you and to bugzilla.kernel org since 2010. A number of
people complained about that, but nothing happened.
Neither your original commit description nor the description of the
PXE_LegNat_Sel I found at other places indicate that setting
PXE_LegNat_Sel could do any harm.
Stephen: It´s a real regression, the fix is known. If you do not want
to go back to setting PXE_LegNat_Sel, you really should allow
dmi_matched fixes.
Mirko, Ralph: Any comments from Marvell?
cu,
Knut
next prev parent reply other threads:[~2012-02-17 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 8:25 [REGRESSION, PATCH] sky2 WOL fix Knut Petersen
2012-02-15 17:16 ` Stephen Hemminger
2012-02-17 18:21 ` Knut Petersen [this message]
2012-02-17 19:01 ` Stephen Hemminger
2012-02-17 20:13 ` Jared
2012-02-17 21:35 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E9AC1.6060704@t-online.de \
--to=knut_petersen@t-online$(echo .)de \
--cc=akpm@osdl$(echo .)org \
--cc=arekm@maven$(echo .)pl \
--cc=davem@davemloft$(echo .)net \
--cc=dilieto@lineone$(echo .)net \
--cc=mlindner@syskonnect$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nitro@legroom$(echo .)net \
--cc=rroesler@syskonnect$(echo .)de \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox