From: Stanislav Kinsbursky <skinsbursky@parallels•com>
To: "Trond.Myklebust@netapp•com" <Trond.Myklebust@netapp•com>
Cc: "linux-nfs@vger•kernel.org" <linux-nfs@vger•kernel.org>,
Pavel Emelianov <xemul@parallels•com>,
"neilb@suse•de" <neilb@suse•de>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
James Bottomley <jbottomley@parallels•com>,
"bfields@fieldses•org" <bfields@fieldses•org>,
"davem@davemloft•net" <davem@davemloft•net>,
"devel@openvz•org" <devel@openvz•org>
Subject: Re: [PATCH v3 1/4] SUNRPC: release per-net clients lock before calling PipeFS dentries creation
Date: Mon, 27 Feb 2012 22:07:14 +0400 [thread overview]
Message-ID: <4F4BC652.6030300@parallels.com> (raw)
In-Reply-To: <20120227180529.1089.29305.stgit@localhost6.localdomain6>
27.02.2012 22:05, Stanislav Kinsbursky пишет:
> v3:
> 1) Lookup for client is performed from the beginning of the list on each PipeFS
> event handling operation.
>
> Lockdep is sad otherwise, because inode mutex is taken on PipeFS dentry
> creation, which can be called on mount notification, where this per-net client
> lock is taken on clients list walk.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels•com>
>
> ---
> net/sunrpc/clnt.c | 26 +++++++++++++++++++++-----
> 1 files changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index bb7ed2f3..48f3d15 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -50,7 +50,7 @@
> __func__, t->tk_status)
>
> /*
> - * All RPC clients are linked into this list
> + * All RPC clients are linked into this list Client Cto hand;le ustatus is checke
> */
>
> static DECLARE_WAIT_QUEUE_HEAD(destroy_wait);
Sorry for this hunk.
--
Best regards,
Stanislav Kinsbursky
next prev parent reply other threads:[~2012-02-27 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 18:05 [PATCH v3 0/4] SUNRPC: several fixes around PipeFS objects Stanislav Kinsbursky
2012-02-27 18:05 ` [PATCH v3 1/4] SUNRPC: release per-net clients lock before calling PipeFS dentries creation Stanislav Kinsbursky
2012-02-27 18:07 ` Stanislav Kinsbursky [this message]
[not found] ` <20120227180509.1089.29555.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-02-27 18:05 ` [PATCH v3 2/4] NFS: " Stanislav Kinsbursky
2012-02-27 18:05 ` [PATCH v3 3/4] SUNRPC: check RPC inode's pipe reference before dereferencing Stanislav Kinsbursky
2012-02-27 18:05 ` [PATCH v3 4/4] SUNRPC: move waitq from RPC pipe to RPC inode Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BC652.6030300@parallels.com \
--to=skinsbursky@parallels$(echo .)com \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=bfields@fieldses$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=jbottomley@parallels$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox