From: Michael Tokarev <mjt@tls•msk.ru>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev <netdev@vger•kernel.org>, David Miller <davem@davemloft•net>
Subject: Re: 3.0: unexpected route cache entry for wrong segment?
Date: Tue, 28 Feb 2012 15:38:36 +0400 [thread overview]
Message-ID: <4F4CBCBC.8000703@msgid.tls.msk.ru> (raw)
In-Reply-To: <1329311013.2437.21.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On 15.02.2012 17:03, Eric Dumazet wrote:
> Le mercredi 15 février 2012 à 16:57 +0400, Michael Tokarev a écrit :
>
>> 3.0.21 included "net: fix NULL dereferences in check_peer_redir()" patch
>> (which is somewhat large(ish) - I wonder why it has been rolled into
>> single patch while in reality it consists of 7 commits; and I wonder
>> why the final result is different from current version in check_peer_redir()
>> routine, which I mentioned in my other email in this thread), but that
>> one does not seem to address this very issue - from a quick view anyway.
>
> That was the tricky part handled by David.
>
> We couldnt apply all needed commits without bringing too many things
> from recent kernels to 3.0 (out of stable scope)
>
> If you believe a fix is needed, just shout :)
I think the a fix is needed. I still don't understand where our
unexpected redirects are coming from, but we had two more occurences
of this very issue. After applying the two patches:
7cc9150ebe8ec06cafea9f1c10d92ddacf88d8ae route: fix ICMP redirect validation
9cc20b268a5a14f5e57b8ad405a83513ab0d78dc ipv4: fix redirect handling
the issue does not occur anymore. The system has been running this
kernel for almost 2 weeks now without any issue of this sort.
The first patch applies to 3.0 as it is, the second needs minor
backporting to 3.0. I already sent the backported version, see
http://patchwork.ozlabs.org/patch/141316/ .
I'm not sure which of the two patches actually helps, but it appears
that both are needed.
Thanks,
/mjt
next prev parent reply other threads:[~2012-02-29 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 17:02 3.0: unexpected route cache entry for wrong segment? Michael Tokarev
2012-02-09 17:45 ` Eric Dumazet
2012-02-09 18:05 ` Eric Dumazet
2012-02-09 18:37 ` Michael Tokarev
2012-02-15 12:10 ` Michael Tokarev
2012-02-15 12:44 ` Michael Tokarev
2012-02-15 12:46 ` Eric Dumazet
2012-02-15 12:57 ` Michael Tokarev
2012-02-15 13:03 ` Eric Dumazet
2012-02-28 11:38 ` Michael Tokarev [this message]
2012-02-28 19:07 ` David Miller
2012-02-29 1:00 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CBCBC.8000703@msgid.tls.msk.ru \
--to=mjt@tls$(echo .)msk.ru \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox