Subject: Re: [PATCH 1/6] stmmac: Define CSUM offload engine Types

From: deepaksi <[email-masked]>
Date: Wed, 7 Mar 2012 12:20:56 +0530

Hello Peppe,

> this patch is useful but I've some notes.
>
> Pay attention that, new GMAC devices have the HW capability register to
> understand if the rx_coe_type is TYPE1 or TYPE2.
> These values should always override the ones come from the platform.
> This check is missing in your code.
> Can I ask you to rename csum_off_engine_type as rx_coe_type to be
> aligned to the name convention used inside the driver.
>
> Regards
> Peppe

Will change the naming convention in this file as well as driver.

Regards
Deepak