From: Roland Stigge <stigge@antcom•de>
To: Arnd Bergmann <arnd@arndb•de>
Cc: davem@davemloft•net, jeffrey.t.kirsher@intel•com,
alexander.h.duyck@intel•com, eilong@broadcom•com,
ian.campbell@citrix•com, netdev@vger•kernel.org,
w.sang@pengutronix•de, linux-kernel@vger•kernel.org,
kevin.wells@nxp•com, linux-arm-kernel@lists•infradead.org,
baruch@tkos•co.il, joe@perches•com
Subject: Re: [PATCH v5] lpc32xx: Added ethernet driver
Date: Wed, 07 Mar 2012 12:53:28 +0100 [thread overview]
Message-ID: <4F574C38.4030006@antcom.de> (raw)
In-Reply-To: <201203062134.38077.arnd@arndb.de>
Hi Arnd,
On 03/06/2012 10:34 PM, Arnd Bergmann wrote:
> This should eventually both become run-time options based on the device tree.
> I don't know if you planned to do that anyway, but if you want the same kernel
> binary to be used for systems in different configurations, you cannot have
> compile-time decisions that are exclusive-or. Since you don't support device
> tree yet but plan to do that in the future, you could add a comment here
> about it, or you could even prepare it for that case already by passing the
> device into the functions that will be required for reading the properties.
Good point.
I prefer putting a comment for now, because upon the planned device tree
introduction in lpc32xx, an internal change in lpc_eth.c will be
necessary anyway, so there is no need to already introduce unused
parameters at this point.
Thanks,
Roland
prev parent reply other threads:[~2012-03-07 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 21:01 [PATCH v5] lpc32xx: Added ethernet driver Roland Stigge
2012-03-06 21:20 ` David Miller
2012-03-06 21:34 ` Arnd Bergmann
2012-03-07 11:53 ` Roland Stigge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F574C38.4030006@antcom.de \
--to=stigge@antcom$(echo .)de \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=baruch@tkos$(echo .)co.il \
--cc=davem@davemloft$(echo .)net \
--cc=eilong@broadcom$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=kevin.wells@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=w.sang@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox