From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, rayagond@vayavyalabs•com
Subject: Re: [net-next 1/4] phy: add the EEE support and the way to access to the MMD regs
Date: Fri, 09 Mar 2012 15:39:45 +0100 [thread overview]
Message-ID: <4F5A1631.9010006@st.com> (raw)
In-Reply-To: <1331231373.2481.7.camel@bwh-desktop>
On 3/8/2012 7:29 PM, Ben Hutchings wrote:
> On Thu, 2012-03-08 at 15:54 +0100, Giuseppe CAVALLARO wrote:
>> Hello Ben
>>
>> thanks for your review and sorry for my delay.
>>
>> On 3/6/2012 6:05 PM, Ben Hutchings wrote:
> [...]
>>>>> +static inline void mmd_phy_cl45(struct mii_bus *bus, int prtad, int devad,
>>>>> + int addr)
>>>> [...]
>>>>> +/**
>>>>> + * read_phy_mmd - reads data from the MMC register (clause 22 to access to
>>>>> + * clause 45)
>>>> [...]
>>>>> +/**
>>>>> + * write_phy_mmd - writes data to the MMC register (clause 22 to access to
>>>>> + * clause 45)
>>>>
>>>> These names need to be changed as phylib also supports (or is intended
>>>> to support) real clause 45 PHYs.
>>
>>
>> What do you suggest? Do I have to rename these functions for example as?
>>
>> write_phy_mmd ----> phy_write_mmd_cl45
>> read_phy_mmd ----> phy_read_mmd_cl45
>
> These are a means to access MMDs through the clause 22 MDIO protocol, so
yes indeed :-)
> it seems to me that the name should include '22' and not '45'. But
> perhaps it would be more obvious to use the word 'indirect'.
ok for phy_write/read_mmd_indirect
>
>> I've also another doubt. I put this code in phy_device.c. Is it correct?
>>
>> Maybe, it could be better have it in phy.c? What do you think?
> [...]
>
> No idea, I don't have any involvement in phylib.
ok. I'll keep the code in phy_device unless to have further feedback
from other developers.
peppe
>
> Ben.
>
next prev parent reply other threads:[~2012-03-09 14:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 12:44 [PATCH 0/4 (net.git)] stmmac EEE support Giuseppe CAVALLARO
2012-02-28 12:44 ` [PATCH 1/4] phy: add the EEE support and the way to access to the MMD regs Giuseppe CAVALLARO
2012-02-28 12:44 ` [PATCH 2/4] net: ethtool: add the EEE support Giuseppe CAVALLARO
2012-02-28 15:45 ` Ben Hutchings
2012-02-29 16:12 ` Giuseppe CAVALLARO
2012-02-29 17:00 ` Ben Hutchings
2012-02-28 12:44 ` [PATCH 3/4] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-02-28 12:44 ` [PATCH 4/4] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
2012-02-28 12:46 ` [PATCH] ethtool: add the EEE option Giuseppe CAVALLARO
2012-02-28 20:18 ` [PATCH 0/4 (net.git)] stmmac EEE support David Miller
2012-02-29 16:07 ` Giuseppe CAVALLARO
2012-03-06 8:28 ` [net-next 0/4] stmmac: add the " Giuseppe CAVALLARO
2012-03-06 8:28 ` [net-next 1/4] phy: add the EEE support and the way to access to the MMD regs Giuseppe CAVALLARO
2012-03-06 16:55 ` Ben Hutchings
2012-03-06 17:05 ` Ben Hutchings
2012-03-08 14:54 ` Giuseppe CAVALLARO
2012-03-08 18:29 ` Ben Hutchings
2012-03-09 14:39 ` Giuseppe CAVALLARO [this message]
2012-03-06 8:28 ` [net-next 2/4] net: ethtool: add the EEE support Giuseppe CAVALLARO
2012-03-06 16:56 ` Ben Hutchings
2012-03-08 15:14 ` Giuseppe CAVALLARO
2012-03-06 8:28 ` [net-next 3/4] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-03-06 8:28 ` [net-next 4/4] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A1631.9010006@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rayagond@vayavyalabs$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox