public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Gao feng <gaofeng@cn•fujitsu.com>
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: davem@davemloft•net, eric.dumazet@gmail•com, netdev@vger•kernel.org
Subject: Re: [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment
Date: Tue, 20 Mar 2012 09:09:02 +0800	[thread overview]
Message-ID: <4F67D8AE.2070602@cn.fujitsu.com> (raw)
In-Reply-To: <20120319080220.GA29891@secunet.com>

于 2012年03月19日 16:02, Steffen Klassert 写道:
> On Fri, Mar 16, 2012 at 04:57:15PM +0800, Gao feng wrote:
>> Since commit 299b0767(ipv6: Fix IPsec slowpath fragmentation problem)
>> In func ip6_append_data,after call skb_put(skb, fraglen + dst_exthdrlen)
>> the skb->len contains dst_exthdrlen,and we don't reduce dst_exthdrlen at last
>> This will make fraggap>0 in next "while cycle",and cause the size of skb incorrent
> 
> Good catch!
> 
>>
>> Call skb_pull reduce skb->len before next "while cycle"
> 
> I think it would be better to just reserve headroom for
> dst_exthdrlen instead of adding and removing data to/from
> the skb.
> 

Hi steffen & David:

Thanks for your comment.
Agree with you,I will send v2 patch.

next prev parent reply	other threads:[~2012-03-20  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16  8:57 [PATCH] ipv6: fix incorrent ipv6 ipsec packet fragment Gao feng
2012-03-17  4:58 ` David Miller
2012-03-19  8:02 ` Steffen Klassert
2012-03-19 21:21   ` David Miller
2012-03-20  1:09   ` Gao feng [this message]
2012-03-20  3:22   ` [PATCH v2] " Gao feng
2012-03-20  7:58     ` Steffen Klassert
2012-03-20  8:36       ` [PATCH v3] " Gao feng
2012-03-20  8:54         ` Steffen Klassert
2012-03-20  9:40           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F67D8AE.2070602@cn.fujitsu.com \
    --to=gaofeng@cn$(echo .)fujitsu.com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=steffen.klassert@secunet$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox