Subject: Re: [PATCH V1 4/6] net/mlx4_en: Set max rate-limit for a TC

From: Amir Vadai <[email-masked]>
Date: Wed, 21 Mar 2012 15:43:11 +0200

On 03/21/2012 12:12 PM, Eric Dumazet wrote:
> Le mercredi 21 mars 2012 à 11:25 +0200, Amir Vadai a écrit :
>> From: Amir Vadai<[email-masked]>
>>
>> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit
>>
>> To set, enter a space separated list of values in units of 100Mbps.  For
>> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue:
>> echo 50 100 100 100 100 100 100 100 100>  /sys/class/net/eth2/qos/ratelimit
>>
>
> Oh thats not very user friendly.
>
> I suggest one value per file (Its probably a generic /sys rule anyway)
> and not using 100Mps for the unit, even if it is the base granularity of
> this hardware.
>
>
> /sys/class/net/eth2/qos/0/ratelimit
> ...
> /sys/class/net/eth2/qos/7/ratelimit
>
>

Ok, will change the structure to be:

/sys/class/net/eth2/qos/tc0/ratelimit
...
/sys/class/net/eth2/qos/tc7/ratelimit

And use units of 1Mbps

- Amir