From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] sh: sh_eth: Add support SH7734
Date: Fri, 23 Mar 2012 13:56:41 +0900 [thread overview]
Message-ID: <4F6C0289.6080005@renesas.com> (raw)
In-Reply-To: <20120321.165818.1166540551487888245.davem@davemloft.net>
David Miller さんは書きました:
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas•com>
> Date: Wed, 21 Mar 2012 16:13:34 +0900
>
>> Add define of SH7734 register and sh_eth_reset_hw_crc function.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas•com>
>
> This patch doesn't apply cleanly at all, also:
>
>> -#elif defined(CONFIG_CPU_SUBTYPE_SH7763)
>> +#elif defined(CONFIG_CPU_SUBTYPE_SH7734) ||\
>> + defined(CONFIG_CPU_SUBTYPE_SH7763)
>
> This looks terrible, please don't split this line up like that.
>
> If you have to, at least put a space before the backslash at the end
> of the first line and make the "defined" on the second line match up,
> column wise, with the "defined" on the previous line.
>
OK, I will fix this.
Thank you.
Nobuhiro
prev parent reply other threads:[~2012-03-23 4:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 7:13 [PATCH] sh: sh_eth: Add support SH7734 Nobuhiro Iwamatsu
2012-03-21 20:58 ` David Miller
2012-03-23 4:56 ` Nobuhiro Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C0289.6080005@renesas.com \
--to=nobuhiro.iwamatsu.yj@renesas$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox