From: Oliver Hartkopp <socketcan@hartkopp•net>
To: dbaluta@ixiacom•com
Cc: davem@davemloft•net, linux-can@vger•kernel.org,
netdev@vger•kernel.org, Daniel Baluta <daniel.baluta@gmail•com>
Subject: Re: [PATCH] can: fix sparse warning for cgw_list
Date: Mon, 26 Mar 2012 06:04:40 +0200 [thread overview]
Message-ID: <4F6FEAD8.3090203@hartkopp.net> (raw)
In-Reply-To: <1332716750-3455-1-git-send-email-dbaluta@ixiacom.com>
On 26.03.2012 01:05, dbaluta@ixiacom•com wrote:
> From: Daniel Baluta <daniel.baluta@gmail•com>
>
> Make cgw_list static to remove the following sparse warning:
> net/can/gw.c:69:1: warning: symbol 'cgw_list' was not declared.
> Should it be static?
>
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom•com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp•net>
Hello Daniel,
cgw_list is indeed only a local structure. Don't know why i didn't declare it
to be static. If it silences a sparse warning the better :-)
Thanks,
Oliver
> ---
> net/can/gw.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/can/gw.c b/net/can/gw.c
> index 3d79b12..b41acf2 100644
> --- a/net/can/gw.c
> +++ b/net/can/gw.c
> @@ -66,7 +66,7 @@ MODULE_LICENSE("Dual BSD/GPL");
> MODULE_AUTHOR("Oliver Hartkopp <oliver.hartkopp@volkswagen•de>");
> MODULE_ALIAS("can-gw");
>
> -HLIST_HEAD(cgw_list);
> +static HLIST_HEAD(cgw_list);
> static struct notifier_block notifier;
>
> static struct kmem_cache *cgw_cache __read_mostly;
next prev parent reply other threads:[~2012-03-26 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 23:05 [PATCH] can: fix sparse warning for cgw_list dbaluta
2012-03-26 4:04 ` Oliver Hartkopp [this message]
2012-03-26 8:19 ` Marc Kleine-Budde
2012-04-03 16:00 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6FEAD8.3090203@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=daniel.baluta@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dbaluta@ixiacom$(echo .)com \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox