From: Daniel Borkmann <danborkmann@iogearbox•net>
To: Ralf Baechle <ralf@linux-mips•org>
Cc: "David S. Miller" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: [PATCH] rose_dev: fix memcpy-bug in rose_set_mac_address
Date: Tue, 27 Mar 2012 15:27:56 +0200 [thread overview]
Message-ID: <4F71C05C.4040300@iogearbox.net> (raw)
This patch fixes a small bug in rose_set_mac_address. If the current and new
MAC addresses match, then nothing needs to be done. However memcpy was used
instead of memcmp for comparison.
The patch is against the latest net-tree.
Signed-off-by: Daniel Borkmann <daniel.borkmann@tik•ee.ethz.ch>
Cc: Ralf Baechle <ralf@linux-mips•org>
---
net/rose/rose_dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/rose/rose_dev.c b/net/rose/rose_dev.c
index 178ff4f..3c5ce5e 100644
--- a/net/rose/rose_dev.c
+++ b/net/rose/rose_dev.c
@@ -96,7 +96,7 @@ static int rose_set_mac_address(struct net_device *dev, void *addr)
struct sockaddr *sa = addr;
int err;
- if (!memcpy(dev->dev_addr, sa->sa_data, dev->addr_len))
+ if (!memcmp(dev->dev_addr, sa->sa_data, dev->addr_len))
return 0;
if (dev->flags & IFF_UP) {
next reply other threads:[~2012-03-27 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:27 Daniel Borkmann [this message]
2012-03-28 2:49 ` [PATCH] rose_dev: fix memcpy-bug in rose_set_mac_address David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-03-28 8:47 Daniel Borkmann
2012-04-01 20:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71C05C.4040300@iogearbox.net \
--to=danborkmann@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ralf@linux-mips$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox