Subject: Re: [PATCH] net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()

From: Ben Greear <[email-masked]>
Date: Tue, 27 Mar 2012 13:07:18 -0700

On 03/27/2012 12:53 PM, Eric Dumazet wrote:
> Commit f2c31e32b378 (net: fix NULL dereferences in check_peer_redir() )
> added a regression in rt6_fill_node(), leading to rcu_read_lock()
> imbalance.
>
> Thats because NLA_PUT() can make a jump to nla_put_failure label.

Ohhh, how truly awful!  That NLA_PUT with hidden jump seems like
bugs just waiting to happen!

Maybe at least someone clever could make some static analysis tool to
catch that....

I'm back-porting and will test shortly.

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com