Subject: Re: [PATCH] net: fix a potential rcu_read_lock() imbalance in rt6_fill_node()

From: Ben Greear <[email-masked]>
Date: Tue, 27 Mar 2012 13:17:09 -0700

On 03/27/2012 12:53 PM, Eric Dumazet wrote:
> Commit f2c31e32b378 (net: fix NULL dereferences in check_peer_redir() )
> added a regression in rt6_fill_node(), leading to rcu_read_lock()
> imbalance.
>
> Thats because NLA_PUT() can make a jump to nla_put_failure label.
>
> Fix this by using nla_put()
>
> Many thanks to Ben Greear for his help
>
> Reported-by: Ben Greear<[email-masked]>
> Reported-by: Dave Jones<[email-masked]>
> Signed-off-by: Eric Dumazet<[email-masked]>

This does indeed fix the problem for me (tested in the 3.0.25 kernel).
So, please feel free to add:

Tested-by: Ben Greear <[email-masked]>

Thanks,
Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com