From: Pavel Emelyanov <xemul@parallels•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH 2/3] tcp: Initial repair mode
Date: Thu, 29 Mar 2012 13:53:25 +0400 [thread overview]
Message-ID: <4F743115.4000600@parallels.com> (raw)
In-Reply-To: <1332967158.2624.42.camel@bwh-desktop.uk.solarflarecom.com>
On 03/29/2012 12:39 AM, Ben Hutchings wrote:
> On Wed, 2012-03-28 at 19:37 +0400, Pavel Emelyanov wrote:
> [...]
>> * Ability to forcibly bind a socket to a port
>>
>> The sk->sk_reuse is set to 2 denoting, that the socket is question
>> should be bound as if all the others in the system are configured
>> with the SO_REUSEADDR option.
>
> Shouldn't this constant be named?
Agree, I will fix this up.
> [...]
>> --- a/net/ipv4/tcp.c
>> +++ b/net/ipv4/tcp.c
> [...]
>> + case TCP_REPAIR_QUEUE:
>> + if (!tp->repair)
>> + err = -EPERM;
>> + else if (val <= TCP_QUEUES_NR)
>
> Off-by-one.
Oops :( Thanks for noticing!
>> + tp->repair_queue = val;
>> + else
>> + err = -EINVAL;
>> + break;
> [...]
>
next prev parent reply other threads:[~2012-03-29 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 15:36 [PATCH net-next 0/3] TCP connection repair (v3) Pavel Emelyanov
2012-03-28 15:36 ` [PATCH 1/3] tcp: Move code around Pavel Emelyanov
2012-03-28 15:37 ` [PATCH 2/3] tcp: Initial repair mode Pavel Emelyanov
2012-03-28 17:20 ` Glauber Costa
2012-03-29 9:52 ` Pavel Emelyanov
2012-03-28 20:39 ` Ben Hutchings
2012-03-29 9:53 ` Pavel Emelyanov [this message]
2012-03-28 15:38 ` [PATCH 3/3] tcp: Repair socket queues Pavel Emelyanov
2012-03-29 10:30 ` Li Yu
2012-03-29 10:36 ` Pavel Emelyanov
2012-03-29 10:41 ` Li Yu
2012-03-29 10:41 ` Li Yu
-- strict thread matches above, loose matches on Subject: below --
2012-03-06 9:54 [RFC][PATCH 0/3] TCP connection repair (v2) Pavel Emelyanov
2012-03-06 9:55 ` [PATCH 2/3] tcp: Initial repair mode Pavel Emelyanov
2012-03-06 13:11 ` Glauber Costa
2012-03-06 20:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F743115.4000600@parallels.com \
--to=xemul@parallels$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox