Subject: Re: [PATCH net: fix /proc/net/dev regression

From: Ben Greear <[email-masked]>
Date: Tue, 03 Apr 2012 08:36:48 -0700

On 04/03/2012 01:33 AM, Eric Dumazet wrote:
> Commit f04565ddf52 (dev: use name hash for dev_seq_ops) added a second
> regression, as some devices are missing from /proc/net/dev if many
> devices are defined.
>
> When seq_file buffer is filled, the last ->next/show() method is
> canceled (pos value is reverted to value prior ->next() call)
>
> Problem is after above commit, we dont restart the lookup at right
> position in ->start() method.
>
> Fix this by removing the internal 'pos' pointer added in commit, since
> we need to use the 'loff_t *pos' provided by seq_file layer.
>
> This also reverts commit 5cac98dd0 (net: Fix corruption
> in /proc/*/net/dev_mcast), since its not needed anymore.
>
> Reported-by: Ben Greear<[email-masked]>
> Signed-off-by: Eric Dumazet<[email-masked]>
> Cc: Mihai Maruseac<[email-masked]>

This appears to fix the problem.  I do find it mildly irritating
that the ordering is now random in /proc/net/dev, but I guess
that is the price of progress.

Tested-by:  Ben Greear <[email-masked]>

Thanks for the quick fix!

Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com