Subject: Re: [PATCH] stmmac: re-add IFF_UNICAST_FLT for dwmac1000

From: Marc Kleine-Budde <[email-masked]>
Date: Wed, 04 Apr 2012 09:33:21 +0200

On 04/04/2012 08:59 AM, Giuseppe CAVALLARO wrote:
> On 4/3/2012 7:44 PM, Marc Kleine-Budde wrote:
>> In commit (bfab27a stmmac: add the experimental PCI support) the
              ^^^^^^^
> 
> I get another patch associated to this commit:
> 
> git show db8857b
           ^^^^^^^

Copy paste problem on your side?

> commit db8857bf5bd888d763e1984f9449d0b824b39ee1
> Author: Florian Fainelli <[email-masked]>
> Date:   Mon Jan 9 23:59:20 2012 +0000
> 
>     stmmac: use an unique MDIO bus name.
> 
>     Signed-off-by: Florian Fainelli <[email-masked]>
>     Signed-off-by: David S. Miller <[email-masked]>
> 
> 
> maybe, the commit should be:
> 
> git-show bfab27a14
           ^^^^^^^^^

Yes, as I've written in my commit message.

> commit bfab27a146ed4d722c6d399f844f955f29cd2b81
> Author: Giuseppe CAVALLARO <[email-masked]>
> Date:   Wed Dec 21 03:58:19 2011 +0000
> 
>     stmmac: add the experimental PCI support
> 
> 
>> IFF_UNICAST_FLT flag has been removed from the stmmac_mac_device_setup()
>> function. This patch re-adds the flag.
> 
> Yes this flag was removed by this PCI patch.
> So it makes sense to re-add it!
> 
>> Signed-off-by: Marc Kleine-Budde <[email-masked]>
> 
> Acked-by: Giuseppe Cavallaro <[email-masked]>

Tnx.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |