From: John Fastabend <john.r.fastabend@intel•com>
To: Amir Vadai <amirv@mellanox•com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Roland Dreier <roland@purestorage•com>,
Yevgeny Petrilin <yevgenyp@mellanox•com>,
Oren Duer <oren@mellanox•com>,
Amir Vadai <amirv@dev•mellanox.co.il>
Subject: Re: [PATCH net-next V6 7/8] net/dcb: Add an optional max rate attribute
Date: Wed, 04 Apr 2012 08:48:12 -0700 [thread overview]
Message-ID: <4F7C6D3C.7070807@intel.com> (raw)
In-Reply-To: <1333537084-9186-8-git-send-email-amirv@mellanox.com>
On 4/4/2012 3:58 AM, Amir Vadai wrote:
> Although not specified in 8021Qaz spec, it could be useful to enable drivers
> whose HW supports setting a rate limit for an ETS TC. This patch adds this
> optional attribute to DCB netlink. To use it, drivers should implement and
> register the callbacks ieee_setmaxrate and ieee_getmaxrate. The units are 64
> bits long and specified in Kbps to enable usage over both slow and very fast
> networks.
>
> Signed-off-by: Amir Vadai <amirv@mellanox•com>
> ---
> include/linux/dcbnl.h | 5 +++++
> include/net/dcbnl.h | 2 ++
> net/dcb/dcbnl.c | 21 +++++++++++++++++++++
> 3 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/dcbnl.h b/include/linux/dcbnl.h
> index 65a2562..ec8e372 100644
> --- a/include/linux/dcbnl.h
> +++ b/include/linux/dcbnl.h
> @@ -67,6 +67,10 @@ struct ieee_ets {
> __u8 reco_prio_tc[IEEE_8021QAZ_MAX_TCS];
> };
>
> +struct ieee_maxrate {
> + __u64 tc_maxrate[IEEE_8021QAZ_MAX_TCS];
> +};
> +
And I think the last comment. We really should have a comment here describing
what the tc_maxrate field is. Its described in the commit log but its much
harder for implementers to get it wrong when the struct is annotated.
Thanks!
John
next prev parent reply other threads:[~2012-04-04 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 10:57 [PATCH net-next V6 0/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 1/8] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 2/8] net/mlx4_core: set port QoS attributes Amir Vadai
2012-04-04 10:57 ` [PATCH net-next V6 3/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 4/8] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 5/8] net/route: export symbol ip_tos2prio Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 6/8] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-04-04 10:58 ` [PATCH net-next V6 7/8] net/dcb: Add an optional max rate attribute Amir Vadai
2012-04-04 15:48 ` John Fastabend [this message]
2012-04-04 21:56 ` Or Gerlitz
2012-04-04 22:27 ` Or Gerlitz
2012-04-04 22:28 ` David Miller
2012-04-04 22:30 ` Or Gerlitz
2012-04-05 0:23 ` John Fastabend
2012-04-05 0:39 ` Dave Taht
2012-04-04 10:58 ` [PATCH net-next V6 8/8] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7C6D3C.7070807@intel.com \
--to=john.r.fastabend@intel$(echo .)com \
--cc=amirv@dev$(echo .)mellanox.co.il \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oren@mellanox$(echo .)com \
--cc=roland@purestorage$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox