From: Amir Vadai <amirv@mellanox•com>
To: David Miller <davem@davemloft•net>, <john.r.fastabend@intel•com>,
<eric.dumazet@gmail•com>
Cc: <netdev@vger•kernel.org>, <roland@purestorage•com>,
<yevgenyp@mellanox•com>, <oren@mellanox•com>,
<amirv@dev•mellanox.co.il>
Subject: Re: [PATCH net-next V7 0/8] net/mlx4_en: DCB QoS support
Date: Thu, 5 Apr 2012 14:22:16 +0300 [thread overview]
Message-ID: <4F7D8068.1000100@mellanox.com> (raw)
In-Reply-To: <20120405.052828.1474884969422039237.davem@davemloft.net>
On 04/05/2012 12:28 PM, David Miller wrote:
> From: Amir Vadai<amirv@mellanox•com>
> Date: Thu, 5 Apr 2012 10:33:23 +0300
>
>> DCBX version 802.1qaz is supported.
>> User Priority (UP) is set in QP context instead of in WQE (QP Work Queue
>> Element), which means that all traffic from a queue will have the same UP.
>> UP is also set for untagged traffic to be able to classify such traffic too.
>>
>> Mapping from sk_prio to User Priority is done by sch_mqprio mapping. Although
>> confusingly sch_mqprio maps sk_prio to something called TC, it is not related
>> to DCBX's TC, and is interpreted by mlx4_en driver as UP.
>>
>> User can set maximal BW for an ETS TC. This could be done by a new optional
>> attribute added to DCB_ATTR_IEEE called DCBNL DCB_ATTR_IEEE_MAXRATE. It accept
>> an array of 8 64 bits values, 1 for every ETS TC. Units are in Kbps.
>
> All applied, thanks.
>
> Please double check that all the new locations that reference
> ip_tos2prio have a proper dependency on CONFIG_INET.
>
> THanks.
Thank you and to the reviewers.
And Yes, the dependencies are good:
The only new place that uses it is in cma.c which is part of rdma_cm.
rdma_cm depends on CONFIG_INFINIBAND_ADDR_TRANS that depends on
CONFIG_INET
- Amir
prev parent reply other threads:[~2012-04-05 11:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 7:33 [PATCH net-next V7 0/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 1/8] net/mlx4_en: Force user priority by QP attribute Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 2/8] net/mlx4_core: set port QoS attributes Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 3/8] net/mlx4_en: DCB QoS support Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 4/8] net/mlx4_en: sk_prio <=> UP for untagged traffic Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 5/8] net/route: export symbol ip_tos2prio Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 6/8] IB/rdma_cm: TOS <=> UP mapping for IBoE Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 7/8] net/dcb: Add an optional max rate attribute Amir Vadai
2012-04-05 7:33 ` [PATCH net-next V7 8/8] net/mlx4_en: Set max rate-limit for a TC Amir Vadai
2012-04-05 9:28 ` [PATCH net-next V7 0/8] net/mlx4_en: DCB QoS support David Miller
2012-04-05 11:22 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7D8068.1000100@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=amirv@dev$(echo .)mellanox.co.il \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oren@mellanox$(echo .)com \
--cc=roland@purestorage$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox