From: Felix Fietkau <nbd@openwrt•org>
To: "Justin P. Mattock" <justinmattock@gmail•com>
Cc: Sujith Manoharan <c_manoha@qca•qualcomm.com>,
Mohammed Shafi <shafi.wireless@gmail•com>,
Linux-wireless <linux-wireless@vger•kernel.org>,
linux-kernel@vger•kernel.org,
Linux-netdev <netdev@vger•kernel.org>
Subject: Re: ath: DMA failed to stop in 10 ms AR_CR=0x00000024 AR_DIAG_SW=0x02000020 DMADBG_7=0x00008040
Date: Fri, 06 Apr 2012 18:56:19 +0200 [thread overview]
Message-ID: <4F7F2033.4000005@openwrt.org> (raw)
In-Reply-To: <4F7F1C74.7080009@gmail.com>
On 2012-04-06 6:40 PM, Justin P. Mattock wrote:
> On 03/26/2012 07:17 PM, Sujith Manoharan wrote:
>> Justin P. Mattock wrote:
>>> I would have to say this patch above does get rid of this crash I was
>>> seeing. as a quick test I simply connect to a WPA network, then connect
>>> to an open network going back and forth triggers this freeze for me
>>> after applying this I am able to toggle back and forth without a freeze.
>>
>> Thanks for verifying.
>>
>> Sujith
>>
>
>
> From going through the warning message I was playing around and am
> looking at: AH_UNPLUGGED .. seems if I remove this from the code I have
> not seen this warning message.
> is there something wrong with AH_UNPLUGGED = 0x2 ?
> is this the wrong address(0x2)?
>
> the patch that I was using is:
>
> From ea8a7d6ecf8b0706f3f0521cd22cc359b20b9373 Mon Sep 17 00:00:00 2001
> From: "Justin P. Mattock" <justinmattock@gmail•com>
> Date: Sun, 25 Mar 2012 21:53:31 -0700
> Subject: [PATCH] ath_test
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail•com>
>
> ---
> drivers/net/wireless/ath/ath9k/recv.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c
> b/drivers/net/wireless/ath/ath9k/recv.c
> index f4ae3ba..d887cee 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -523,8 +523,7 @@ bool ath_stoprecv(struct ath_softc *sc)
> sc->rx.rxlink = NULL;
> spin_unlock_bh(&sc->rx.rxbuflock);
>
> - if (!(ah->ah_flags & AH_UNPLUGGED) &&
> - unlikely(!stopped)) {
> + if (!(ah->ah_flags) && unlikely(!stopped)) {
That patch is completely messed up - before showing the warning, it
checks if ah_flags is set to 0, which will never happen with most
devices. You're simply making the warning impossible to trigger.
- Felix
prev parent reply other threads:[~2012-04-06 16:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 14:25 ath: DMA failed to stop in 10 ms AR_CR=0x00000024 AR_DIAG_SW=0x02000020 DMADBG_7=0x00008040 Justin P. Mattock
2012-03-07 15:19 ` Mohammed Shafi
2012-03-07 15:24 ` Justin P. Mattock
[not found] ` <4F577D9B.7020402-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-07 17:27 ` Felix Fietkau
2012-03-07 17:37 ` Justin P. Mattock
[not found] ` <4F579A88.6030503-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-03-08 21:18 ` Justin P. Mattock
2012-03-15 13:57 ` Justin P. Mattock
2012-03-16 19:45 ` Justin P. Mattock
2012-03-19 14:43 ` Justin P. Mattock
2012-03-19 15:20 ` Mohammed Shafi
2012-03-19 15:25 ` Justin P. Mattock
2012-03-19 15:33 ` Felix Fietkau
2012-03-19 16:09 ` Justin P. Mattock
[not found] ` <4F6751B2.1030809-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-03-20 5:54 ` Justin P. Mattock
2012-03-20 6:19 ` Mohammed Shafi
2012-03-20 6:27 ` Justin P. Mattock
2012-03-20 6:32 ` Mohammed Shafi
2012-03-20 6:36 ` Justin P. Mattock
2012-03-20 7:44 ` Mohammed Shafi
[not found] ` <CAD2nsn2b9yVrX16m4Pc0F96PHF09ySv8ncY8Qnr7_9CC8hrbtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-25 15:05 ` Justin P. Mattock
[not found] ` <4F682555.3020502-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-20 8:29 ` Sujith Manoharan
2012-03-20 9:37 ` Mohammed Shafi
2012-03-20 11:15 ` Mohammed Shafi
2012-03-20 11:36 ` Mohammed Shafi
2012-03-20 11:46 ` Mohammed Shafi
2012-03-20 14:19 ` Justin P. Mattock
2012-03-20 15:22 ` Sujith Manoharan
2012-03-20 17:42 ` Justin P. Mattock
2012-03-25 23:00 ` Justin P. Mattock
[not found] ` <4F6FA388.9080408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-03-27 2:17 ` Sujith Manoharan
2012-04-06 16:40 ` Justin P. Mattock
2012-04-06 16:56 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F2033.4000005@openwrt.org \
--to=nbd@openwrt$(echo .)org \
--cc=c_manoha@qca$(echo .)qualcomm.com \
--cc=justinmattock@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shafi.wireless@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox