From: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public•gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public•gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public•gmane.org>
Subject: Re: [PATCH v3 1/2] cgroup: pass struct mem_cgroup instead of struct cgroup to socket memcg
Date: Tue, 10 Apr 2012 11:42:52 +0900 [thread overview]
Message-ID: <4F839E2C.20000@jp.fujitsu.com> (raw)
In-Reply-To: <1334010994-23301-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
(2012/04/10 7:36), Glauber Costa wrote:
> The only reason cgroup was used, was to be consistent with the populate()
> interface. Now that we're getting rid of it, not only we no longer need
> it, but we also *can't* call it this way.
>
> Since we will no longer rely on populate(), this will be called from
> create(). During create, the association between struct mem_cgroup
> and struct cgroup does not yet exist, since cgroup internals hasn't
> yet initialized its bookkeeping. This means we would not be able
> to draw the memcg pointer from the cgroup pointer in these
> functions, which is highly undesirable.
>
> Signed-off-by: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public•gmane.org>
> CC: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>
> CC: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public•gmane.org>
> CC: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public•gmane.org>
> CC: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public•gmane.org>
> CC: Michal Hocko <mhocko-AlSwsSmVLrQ@public•gmane.org>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public•gmane.org>
next prev parent reply other threads:[~2012-04-10 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 22:36 [PATCH v3 0/2] get rid of populate for memcg Glauber Costa
[not found] ` <1334010994-23301-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-09 22:36 ` [PATCH v3 1/2] cgroup: pass struct mem_cgroup instead of struct cgroup to socket memcg Glauber Costa
[not found] ` <1334010994-23301-2-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-10 2:42 ` KAMEZAWA Hiroyuki [this message]
2012-04-09 22:36 ` [PATCH v3 2/2] cgroup: get rid of populate for memcg Glauber Costa
2012-04-09 22:42 ` Tejun Heo
[not found] ` <1334010994-23301-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-04-10 2:44 ` KAMEZAWA Hiroyuki
[not found] ` <4F839E73.1000204-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-04-10 17:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F839E2C.20000@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public$(echo .)gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public$(echo .)gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public$(echo .)gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox