From: Ben Greear <greearb@candelatech•com>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: "David Miller" <davem@davemloft•net>,
"Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
netdev@vger•kernel.org
Subject: Re: Please revert removal of /sys/class/net/*/features
Date: Tue, 10 Apr 2012 11:32:23 -0700 [thread overview]
Message-ID: <4F847CB7.3040603@candelatech.com> (raw)
In-Reply-To: <20120410110851.5690739c@nehalam.linuxnetplumber.net>
On 04/10/2012 11:08 AM, Stephen Hemminger wrote:
> This commit needs to be reverted. It removed an available sysfs file, and sysfs
> files are part of the ABI. It caused a bug in our current release of Vyatta because
> the shell script was using the sysfs file to see if VLAN was supported on a device.
It's a hack, but you can also make some vlan IOCTL calls to a device
to probe if it's VLAN or not..thats what I've been doing for the last
decade or so :)
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2012-04-10 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 18:08 Please revert removal of /sys/class/net/*/features Stephen Hemminger
2012-04-10 18:27 ` David Miller
2012-04-10 18:32 ` Ben Greear [this message]
2012-04-10 19:59 ` Michał Mirosław
2012-04-10 20:25 ` Ben Hutchings
2012-04-10 20:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F847CB7.3040603@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox