Subject: Re: [PATCH 05/10] mac80211: Add more ethtools stats: survey, rates, etc

From: Ben Greear <greearb-my8/[email-masked]>
Date: Wed, 11 Apr 2012 11:01:35 -0700

On 04/11/2012 10:52 AM, greearb-my8/[email-masked] wrote:
> From: Ben Greear<greearb-my8/[email-masked]>
>
> The signal and noise are forced to be positive since ethtool
> deals in unsigned 64-bit values and this number should be human
> readable.  This gives easy access to some of the data formerly
> exposed in the deprecated /proc/net/wireless file.

> +	if (WARN_ON(i != STA_STATS_LEN)) {
> +		rcu_read_unlock();
> +		return;
> +	}
> +
> +	drv_get_et_stats(sdata, stats,&(data[STA_STATS_LEN]));
> +}
> +

Ahh crap, I missed an rcu_read_unlock here...will fix this
and whatever else folks suggest and repost..but don't apply
this patch as is!

Thanks,
Ben

-- 
Ben Greear <greearb-my8/[email-masked]>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html