public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>
To: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public•gmane.org>
Cc: <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	Robert Love <rlove-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org>,
	"John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>,
	ath6kl-devel
	<ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w@public•gmane.org>
Subject: Re: [PATCH] ath6kl: fix memory leak in ath6kl_fwlog_block_read()
Date: Mon, 16 Apr 2012 09:07:49 +0300	[thread overview]
Message-ID: <4F8BB735.4040409@qca.qualcomm.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204112239070.2137-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>

On 04/11/2012 11:41 PM, Jesper Juhl wrote:
> If, in
> drivers/net/wireless/ath/ath6kl/debug.c::ath6kl_fwlog_block_read(),
> the call to wait_for_completion_interruptible() returns -ERESTARTSYS
> then we'll return without freeing the (as yet unused) memory we
> allocated for 'buf' - thus leaking it.
> 
> Signed-off-by: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public•gmane.org>

Thanks, applied to ath6kl.git.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2012-04-16  6:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 20:41 [PATCH] ath6kl: fix memory leak in ath6kl_fwlog_block_read() Jesper Juhl
     [not found] ` <alpine.LNX.2.00.1204112239070.2137-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2012-04-16  6:07   ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8BB735.4040409@qca.qualcomm.com \
    --to=kvalo-a+znkfmmk5xy9ajcnzt0uw@public$(echo .)gmane.org \
    --cc=ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w@public$(echo .)gmane.org \
    --cc=jj-IYz4IdjRLj0sV2N9l4h3zg@public$(echo .)gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=rlove-hpIqsD4AKlfQT0dZR+AlfA@public$(echo .)gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox