From: Prasanna Panchamukhi <ppanchamukhi@riverbed•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
davem@davemloft•net, netdev@vger•kernel.org, gospo@redhat•com,
sassmann@redhat•com
Subject: Re: [net 1/2] e1000e: MSI interrupt test failed, using legacy interrupt
Date: Wed, 25 Apr 2012 15:46:00 -0700 [thread overview]
Message-ID: <4F987EA8.6090700@riverbed.com> (raw)
In-Reply-To: <1335369547.2602.3.camel@bwh-desktop.uk.solarflarecom.com>
On 04/25/2012 08:59 AM, Ben Hutchings wrote:
> On Tue, 2012-04-24 at 22:55 -0700, Jeff Kirsher wrote:
>> From: Prasanna S Panchamukhi<ppanchamukhi@riverbed•com>
>>
>> Following logs where seen on Systems with multiple NICs,
>> while using MSI interrupts as shown below:
> [...]
>> This patch fixes this problem by increasing the msleep from 50 to 100.
> [...]
>
> It probably doesn't, in general. The out-of-tree version of the sfc
> driver used to perform an interrupt test during probe, and after fixing
> it up repeatedly I eventually had to remove it completely as there are
> so many ways to get a false negative. Also see the related commit
> 93e5dfa59b0e26a145a8adce5c9edf50bdaef4c7 ('sfc: Raise self-test
> timeouts').
>
Thanks Ben for your review.
In general Ben's approach looks good fix to avoid false negatives. To
give a little
bit of background, this issues is seen mostly with Intel 82571 Dual/quad
port Gigabit ethernet controller add-on NICs and not seen with other
Intel ethernet controller NICs. If Ben suggested
approach is the best way to go, I will provide a patch soon.
Thanks,
Prasanna
> Ben.
>
next prev parent reply other threads:[~2012-04-25 22:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 5:55 [net 0/2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-04-25 5:55 ` [net 1/2] e1000e: MSI interrupt test failed, using legacy interrupt Jeff Kirsher
2012-04-25 15:59 ` Ben Hutchings
2012-04-25 22:46 ` Prasanna Panchamukhi [this message]
2012-04-25 5:55 ` [net 2/2] e1000e: Fix default interrupt throttle rate not set in NIC HW Jeff Kirsher
2012-04-26 9:11 ` [net 0/2][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F987EA8.6090700@riverbed.com \
--to=ppanchamukhi@riverbed$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prasanna.panchamukhi@riverbed$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox