From: "Arend van Spriel" <arend@broadcom•com>
To: "Joe Perches" <joe@perches•com>
Cc: "David Miller" <davem@davemloft•net>,
linville@tuxdriver•com, linux-wireless@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: pull request: wireless-next 2012-05-03
Date: Fri, 4 May 2012 10:57:05 +0200 [thread overview]
Message-ID: <4FA399E1.5080708@broadcom.com> (raw)
In-Reply-To: <1336066186.13866.25.camel@joe2Laptop>
On 05/03/2012 07:29 PM, Joe Perches wrote:
> On Thu, 2012-05-03 at 13:17 -0400, David Miller wrote:
>> ...
>> - if (hdev->discovery.type == DISCOV_TYPE_INTERLEAVED) {
>> + if (hdev->discovery.type == DISCOV_TYPE_INTERLEAVED &&
>> + hdev->discovery.state == DISCOVERY_FINDING) {
>>
>> Really, we went through this a million times very recently and I'm
>> not pulling anything into my tree that has garbage like this in it.
>
> Perhaps the bluetooth folk can adopt using
>
> scripts/checkpatch.pl --strict
>
> or maybe checkpatch could be changed to use
> --strict on patches in net and drivers/net
> automatically.
When the --strict option was added it made me wonder if that meant we
should add this option in Documentation/SubmittingPatches. I do not see
why the patches for net subsystem should have a different check level.
So why not do --strict by default and get rid of the option flag.
Gr. AvS
next prev parent reply other threads:[~2012-05-04 8:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 15:22 pull request: wireless-next 2012-05-03 John W. Linville
[not found] ` <20120503152206.GL9285-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2012-05-03 17:05 ` David Miller
[not found] ` <20120503.130516.1008806127286088740.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-03 17:17 ` David Miller
2012-05-03 17:21 ` David Miller
[not found] ` <20120503.131707.112550136096227430.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-03 17:28 ` John W. Linville
2012-05-03 17:29 ` Joe Perches
2012-05-04 8:57 ` Arend van Spriel [this message]
2012-05-04 9:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA399E1.5080708@broadcom.com \
--to=arend@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=joe@perches$(echo .)com \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox